Bug 1413284 - A RangeError exception is thrown if start/stop is called with a out of range param r=padenot draft
authormaxLanglade <maxime.langlade@etu.univ-lyon1.fr>
Wed, 18 Jul 2018 21:32:14 +0200
changeset 820826 e2a4f44072d568c5960994f330bb9550bc05830e
parent 820825 e6f3b9a33390d8c249ea491ab50f1b136b8973b8
child 820827 5d98a2d1b50bd826b5df815e2f152d3615304dc1
push id116948
push userpaul@paul.cx
push dateFri, 20 Jul 2018 13:24:54 +0000
reviewerspadenot
bugs1413284
milestone63.0a1
Bug 1413284 - A RangeError exception is thrown if start/stop is called with a out of range param r=padenot MozReview-Commit-ID: G65bFgMu10D
dom/media/webaudio/ConstantSourceNode.cpp
--- a/dom/media/webaudio/ConstantSourceNode.cpp
+++ b/dom/media/webaudio/ConstantSourceNode.cpp
@@ -205,17 +205,17 @@ ConstantSourceNode::DestroyMediaStream()
   }
   AudioNode::DestroyMediaStream();
 }
 
 void
 ConstantSourceNode::Start(double aWhen, ErrorResult& aRv)
 {
   if (!WebAudioUtils::IsTimeValid(aWhen)) {
-    aRv.Throw(NS_ERROR_DOM_NOT_SUPPORTED_ERR);
+    aRv.Throw(NS_ERROR_RANGE_ERR);
     return;
   }
 
   if (mStartCalled) {
     aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
     return;
   }
   mStartCalled = true;
@@ -229,17 +229,17 @@ ConstantSourceNode::Start(double aWhen, 
 
   MarkActive();
 }
 
 void
 ConstantSourceNode::Stop(double aWhen, ErrorResult& aRv)
 {
   if (!WebAudioUtils::IsTimeValid(aWhen)) {
-    aRv.Throw(NS_ERROR_DOM_NOT_SUPPORTED_ERR);
+    aRv.Throw(NS_ERROR_RANGE_ERR);
     return;
   }
 
   if (!mStartCalled) {
     aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
     return;
   }