Bug 1470394 - Make bookmark panel width localizable. r?mak draft
authorDão Gottwald <dao@mozilla.com>
Wed, 18 Jul 2018 14:08:53 +0200
changeset 819725 3f3afc70f06bf68f0e9444e11985cba57e435a30
parent 819645 8dab948a10f073a46f13f55f94d1f6514c7360ac
push id116624
push userdgottwald@mozilla.com
push dateWed, 18 Jul 2018 12:09:23 +0000
reviewersmak
bugs1470394
milestone63.0a1
Bug 1470394 - Make bookmark panel width localizable. r?mak MozReview-Commit-ID: 5vtMOxxlQH6
browser/base/content/browser.xul
browser/locales/en-US/chrome/browser/browser.dtd
browser/themes/linux/places/editBookmark.css
browser/themes/osx/places/editBookmark.css
browser/themes/windows/places/editBookmark.css
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -237,17 +237,19 @@
       <box class="panel-header">
         <label id="editBookmarkPanelTitle"/>
       </box>
       <html:div id="editBookmarkPanelFaviconContainer">
         <html:img id="editBookmarkPanelFavicon"/>
       </html:div>
       <box id="editBookmarkPanelImage"/>
 #include ../../components/places/content/editBookmarkPanel.inc.xul
-      <vbox id="editBookmarkPanelBottomContent" flex="1">
+      <vbox id="editBookmarkPanelBottomContent"
+            flex="1"
+            style="min-width: &editBookmark.panel.width;;">
         <checkbox id="editBookmarkPanel_showForNewBookmarks"
                   label="&editBookmark.showForNewBookmarks.label;"
                   accesskey="&editBookmark.showForNewBookmarks.accesskey;"
                   oncommand="StarUI.onShowForNewBookmarksCheckboxCommand();"/>
       </vbox>
       <hbox id="editBookmarkPanelBottomButtons" pack="end">
 #ifndef XP_UNIX
         <button id="editBookmarkPanelDoneButton"
--- a/browser/locales/en-US/chrome/browser/browser.dtd
+++ b/browser/locales/en-US/chrome/browser/browser.dtd
@@ -749,16 +749,20 @@ you can use these alternative items. Oth
 <!ENTITY findAgainCmd.accesskey "g">
 <!ENTITY findAgainCmd.commandkey "g">
 <!ENTITY findAgainCmd.commandkey2 "VK_F3">
 <!ENTITY findSelectionCmd.commandkey "e">
 
 <!ENTITY spellAddDictionaries.label "Add Dictionaries…">
 <!ENTITY spellAddDictionaries.accesskey "A">
 
+<!-- LOCALIZATION NOTE (editBookmark.panel.width): width of the bookmark panel.
+     Should be large enough to fully display the Done and Cancel/
+     Remove Bookmark buttons. -->
+<!ENTITY editBookmark.panel.width                    "23em">
 <!ENTITY editBookmark.done.label                     "Done">
 <!ENTITY editBookmark.showForNewBookmarks.label       "Show editor when saving">
 <!ENTITY editBookmark.showForNewBookmarks.accesskey   "S">
 
 <!-- LOCALIZATION NOTE (identity.securityView.label)
      This is the header of the security subview in the Site Identity panel. -->
 <!ENTITY identity.securityView.label "Site Security">
 
--- a/browser/themes/linux/places/editBookmark.css
+++ b/browser/themes/linux/places/editBookmark.css
@@ -35,20 +35,16 @@
 .expander-up > .button-box {
   -moz-appearance: button-arrow-up;
 }
 
 .expander-down > .button-box {
   -moz-appearance: button-arrow-down;
 }
 
-#editBookmarkPanelContent {
-  min-width: 23em;
-}
-
 #editBMPanel_folderTree {
   margin-top: 2px;
   margin-bottom: 2px;
 }
 
 /* Hide the value column of the tag autocomplete popup
  * leaving only the comment column visible. This is
  * so that only the tag being edited is shown in the
--- a/browser/themes/osx/places/editBookmark.css
+++ b/browser/themes/osx/places/editBookmark.css
@@ -38,20 +38,16 @@
 .expander-up {
   -moz-appearance: -moz-mac-disclosure-button-open;
 }
 
 .expander-down {
   -moz-appearance: -moz-mac-disclosure-button-closed;
 }
 
-#editBookmarkPanelContent {
-  min-width: 23em;
-}
-
 #editBMPanel_folderTree {
   margin: 6px 4px 0 4px;
 }
 
 /* Hide the value column of the tag autocomplete popup
  * leaving only the comment column visible. This is
  * so that only the tag being edited is shown in the
  * popup.
--- a/browser/themes/windows/places/editBookmark.css
+++ b/browser/themes/windows/places/editBookmark.css
@@ -40,20 +40,16 @@
 .expander-up {
   list-style-image: url("chrome://global/skin/icons/collapse.png");
 }
 
 .expander-down {
   list-style-image: url("chrome://global/skin/icons/expand.png");
 }
 
-#editBookmarkPanelContent {
-  min-width: 23em;
-}
-
 #editBMPanel_folderTree {
   margin-top: 2px;
   margin-bottom: 2px;
 }
 
 /* Hide the value column of the tag autocomplete popup
  * leaving only the comment column visible. This is
  * so that only the tag being edited is shown in the