Bug 1476158 - Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref; r?bz draft
authorBrian Birtles <birtles@gmail.com>
Wed, 18 Jul 2018 10:32:33 +0900
changeset 819533 13e3a4fc0381d6eff08d50849408498a7e6fcde9
parent 819486 afa310dc89beeb4b7a9564d2c89ff32906f427ad
child 819534 523c9f173f510e0a1fd0bf6ac83130a53a5e7dcf
push id116576
push userbmo:bbirtles@mozilla.com
push dateWed, 18 Jul 2018 03:26:15 +0000
reviewersbz
bugs1476158, 1471814
milestone63.0a1
Bug 1476158 - Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref; r?bz The CSSAnimation and CSSTransition interfaces are only needed to represent CSS animations and CSS transitions returned by the {Document,Element}.getAnimations() API. Bug 1471814 introduced the dom.animations-api.getAnimations.enabled pref but neglected to guard the CSSAnimation and CSSTransition interfaces behind this pref, leaving them guarded by the dom.animations-api.core.enabled pref instead. This patch updates the pref used to guard these interfaces so that when we turn on the dom.animations-api.core.enabled pref by default we don't also end up shipping these interfaces. MozReview-Commit-ID: GjfvOltxlJy
dom/webidl/CSSAnimation.webidl
dom/webidl/CSSTransition.webidl
--- a/dom/webidl/CSSAnimation.webidl
+++ b/dom/webidl/CSSAnimation.webidl
@@ -5,13 +5,13 @@
  *
  * The origin of this IDL file is
  * http://dev.w3.org/csswg/css-animations-2/#the-CSSAnimation-interface
  *
  * Copyright © 2015 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
  */
 
-[Func="nsDocument::IsWebAnimationsEnabled",
+[Func="nsDocument::IsWebAnimationsGetAnimationsEnabled",
  HeaderFile="nsAnimationManager.h"]
 interface CSSAnimation : Animation {
   [Constant] readonly attribute DOMString animationName;
 };
--- a/dom/webidl/CSSTransition.webidl
+++ b/dom/webidl/CSSTransition.webidl
@@ -5,13 +5,13 @@
  *
  * The origin of this IDL file is
  * http://dev.w3.org/csswg/css-transitions-2/#the-CSSTransition-interface
  *
  * Copyright © 2015 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
  */
 
-[Func="nsDocument::IsWebAnimationsEnabled",
+[Func="nsDocument::IsWebAnimationsGetAnimationsEnabled",
  HeaderFile="nsTransitionManager.h"]
 interface CSSTransition : Animation {
   [Constant] readonly attribute DOMString transitionProperty;
 };