Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. draft
authorRobert Bartlensky <rbartlensky@mozilla.com>
Tue, 17 Jul 2018 12:32:42 +0100
changeset 820747 505b2e19b5029a1fd9fa5df5c03f734c5f99dc89
parent 820696 4aa8eb6e5ca75109e97e0c3f64c5529fd74c94eb
push id116920
push userbmo:rbartlensky@mozilla.com
push dateFri, 20 Jul 2018 10:16:02 +0000
bugs1476016
milestone63.0a1
Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. MozReview-Commit-ID: F1p3ji1ezp3
netwerk/mime/nsMIMEHeaderParamImpl.cpp
--- a/netwerk/mime/nsMIMEHeaderParamImpl.cpp
+++ b/netwerk/mime/nsMIMEHeaderParamImpl.cpp
@@ -447,17 +447,17 @@ nsMIMEHeaderParamImpl::DoParameterIntern
 
   int32_t paramLen = strlen(aParamName);
 
   while (*str) {
     // find name/value
 
     const char *nameStart = str;
     const char *nameEnd = nullptr;
-    const char *valueStart = str;
+    const char *valueStart = nullptr;
     const char *valueEnd = nullptr;
     bool isQuotedString = false;
 
     NS_ASSERTION(!nsCRT::IsAsciiSpace(*str), "should be after whitespace.");
 
     // Skip forward to the end of this token.
     for (; *str && !nsCRT::IsAsciiSpace(*str) && *str != '=' && *str != ';'; str++)
       ;