Bug 1475382 - Turn off async content process launching, pending better error handling. r?spohl draft
authorJed Davis <jld@mozilla.com>
Fri, 13 Jul 2018 15:20:25 -0600
changeset 819078 dce6171c3fd4066f115f74f56a0f50772dbb2878
parent 819077 dbc24fdab7767eb94d4518bfad68b0193221b248
child 819079 b1cb322614aeae0d210ceeabed3884a936f1e9a4
push id116432
push userbmo:jld@mozilla.com
push dateTue, 17 Jul 2018 04:26:12 +0000
reviewersspohl
bugs1475382
milestone63.0a1
Bug 1475382 - Turn off async content process launching, pending better error handling. r?spohl At the moment this isn't actually async because we immediately require the pid and block on launch anyway. It also crashes the entire browser on otherwise recoverable launch errors, because code that wants the pid isn't set up to handle that operation failing. MozReview-Commit-ID: 5favGu34QCv
dom/ipc/moz.build
ipc/glue/moz.build
--- a/dom/ipc/moz.build
+++ b/dom/ipc/moz.build
@@ -179,18 +179,15 @@ MOCHITEST_CHROME_MANIFESTS += ['tests/ch
 MOCHITEST_MANIFESTS += ['tests/mochitest.ini']
 XPCSHELL_TESTS_MANIFESTS += ['tests/xpcshell.ini']
 
 CXXFLAGS += CONFIG['TK_CFLAGS']
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-Wno-error=shadow']
 
-if CONFIG['NIGHTLY_BUILD']:
-    DEFINES['ASYNC_CONTENTPROC_LAUNCH'] = True
-
 if CONFIG['FUZZING'] and CONFIG['FUZZING_INTERFACES']:
     TEST_DIRS += [
         'fuzztest'
     ]
 
 # Add libFuzzer configuration directives
 include('/tools/fuzzing/libfuzzer-config.mozbuild')
--- a/ipc/glue/moz.build
+++ b/ipc/glue/moz.build
@@ -232,13 +232,10 @@ if CONFIG['MOZ_SANDBOX'] and CONFIG['OS_
         '/security/sandbox/chromium',
         '/security/sandbox/chromium-shim',
         '/security/sandbox/win/src/sandboxbroker',
     ]
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-Wno-shadow']
 
-if CONFIG['NIGHTLY_BUILD']:
-    DEFINES['ASYNC_CONTENTPROC_LAUNCH'] = True
-
 # Add libFuzzer configuration directives
 include('/tools/fuzzing/libfuzzer-config.mozbuild')