Bug 1475283: Fix DEAD_STORE reported by infer in nsTypeAheadFind.cpp. r?froydnj draft
authorRobert Bartlensky <rbartlensky@mozilla.com>
Mon, 16 Jul 2018 18:38:16 +0100
changeset 820379 d30201e2ca91ea81c66c1581c2a42a120097e0ba
parent 820343 183ee39bf309cd8463d8db5b5c8eb232cd0dac53
push id116801
push userbmo:rbartlensky@mozilla.com
push dateThu, 19 Jul 2018 13:20:51 +0000
reviewersfroydnj
bugs1475283
milestone63.0a1
Bug 1475283: Fix DEAD_STORE reported by infer in nsTypeAheadFind.cpp. r?froydnj MozReview-Commit-ID: 720l6iKMVGl
toolkit/components/typeaheadfind/nsTypeAheadFind.cpp
--- a/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp
+++ b/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp
@@ -111,16 +111,17 @@ nsTypeAheadFind::Init(nsIDocShell* aDocS
     return NS_ERROR_FAILURE;
 
   SetDocShell(aDocShell);
 
   if (!mDidAddObservers) {
     mDidAddObservers = true;
     // ----------- Listen to prefs ------------------
     nsresult rv = prefInternal->AddObserver("accessibility.browsewithcaret", this, true);
+    NS_ENSURE_SUCCESS(rv, rv);
     rv = prefInternal->AddObserver("accessibility.typeaheadfind", this, true);
     NS_ENSURE_SUCCESS(rv, rv);
 
     // ----------- Get initial preferences ----------
     PrefsReset();
 
     nsCOMPtr<nsIObserverService> os = mozilla::services::GetObserverService();
     if (os) {