Bug 1474364 - Clear the stored flexbox highlighter shown before emitting the event. r=pbro draft
authorGabriel Luong <gabriel.luong@gmail.com>
Fri, 13 Jul 2018 14:28:45 -0400
changeset 817943 9ca5e34eeed70d59d80952a8887b820d96a87cc0
parent 817942 3587c059bdd04fa2289c250817c8742f0c2700fe
push id116224
push userbmo:gl@mozilla.com
push dateFri, 13 Jul 2018 18:29:22 +0000
reviewerspbro
bugs1474364
milestone63.0a1
Bug 1474364 - Clear the stored flexbox highlighter shown before emitting the event. r=pbro MozReview-Commit-ID: BWDX2nMjnx8
devtools/client/inspector/shared/highlighters-overlay.js
--- a/devtools/client/inspector/shared/highlighters-overlay.js
+++ b/devtools/client/inspector/shared/highlighters-overlay.js
@@ -280,18 +280,19 @@ class HighlightersOverlay {
     }
 
     this._toggleRuleViewIcon(node, false, ".ruleview-flex");
 
     await this.highlighters.FlexboxHighlighter.hide();
 
     // Emit the NodeFront of the flexbox container element that the flexbox highlighter
     // was hidden for.
-    this.emit("flexbox-highlighter-hidden", this.flexboxHighlighterShown);
+    const nodeFront = this.flexboxHighlighterShown;
     this.flexboxHighlighterShown = null;
+    this.emit("flexbox-highlighter-hidden", nodeFront);
 
     // Erase flexbox highlighter state.
     this.state.flexbox = null;
   }
 
   /**
    * Create a grid highlighter settings object for the provided nodeFront.
    *