Bug 1421091 - Remove a bit from a gtest that is tested directly in the bindings. r?jya draft
authorPaul Adenot <paul@paul.cx>
Fri, 13 Jul 2018 14:31:53 +0200
changeset 817812 a2ae07f5128ea5934abf048aca03f97620d1591d
parent 817794 7dc9bcda2af91025c8a7cdc673630df7747b409d
child 817813 de4a87be9a56b2a9dbf4cf4b393b8ad9b12db7d3
child 817822 a06edb8c9a00283d8f55aae3ed7931cee891a1c2
push id116168
push userpaul@paul.cx
push dateFri, 13 Jul 2018 13:16:43 +0000
reviewersjya
bugs1421091
milestone63.0a1
Bug 1421091 - Remove a bit from a gtest that is tested directly in the bindings. r?jya This cannot happen anymore, because we're using sequence<float> and not Float32Array in WebIDL, and sequence<float> throws when it contains Infinity or NaN. MozReview-Commit-ID: 9ZUbXa0viSk
dom/media/webaudio/gtest/TestAudioEventTimeline.cpp
--- a/dom/media/webaudio/gtest/TestAudioEventTimeline.cpp
+++ b/dom/media/webaudio/gtest/TestAudioEventTimeline.cpp
@@ -157,19 +157,16 @@ TEST(AudioEventTimeline, SpecExample)
 TEST(AudioEventTimeline, InvalidEvents)
 {
   static_assert(numeric_limits<float>::has_quiet_NaN, "Platform must have a quiet NaN");
   const float NaN = numeric_limits<float>::quiet_NaN();
   const float Infinity = numeric_limits<float>::infinity();
   Timeline timeline(10.0f);
 
   float curve[] = { -1.0f, 0.0f, 1.0f };
-  float badCurve1[] = { -1.0f, NaN, 1.0f };
-  float badCurve2[] = { -1.0f, Infinity, 1.0f };
-  float badCurve3[] = { -1.0f, -Infinity, 1.0f };
 
   ErrorResultMock rv;
 
   timeline.SetValueAtTime(NaN, 0.1, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetValueAtTime(Infinity, 0.1, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetValueAtTime(-Infinity, 0.1, rv);
@@ -197,22 +194,16 @@ TEST(AudioEventTimeline, InvalidEvents)
   timeline.SetTargetAtTime(0.4f, NaN, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetTargetAtTime(0.4f, Infinity, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetTargetAtTime(0.4f, -Infinity, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetValueCurveAtTime(nullptr, 0, 1.0, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
-  timeline.SetValueCurveAtTime(badCurve1, ArrayLength(badCurve1), 1.0, 1.0, rv);
-  is(rv, NS_ERROR_TYPE_ERR, "Correct error code returned");
-  timeline.SetValueCurveAtTime(badCurve2, ArrayLength(badCurve2), 1.0, 1.0, rv);
-  is(rv, NS_ERROR_TYPE_ERR, "Correct error code returned");
-  timeline.SetValueCurveAtTime(badCurve3, ArrayLength(badCurve3), 1.0, 1.0, rv);
-  is(rv, NS_ERROR_TYPE_ERR, "Correct error code returned");
   timeline.SetValueCurveAtTime(curve, ArrayLength(curve), NaN, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetValueCurveAtTime(curve, ArrayLength(curve), Infinity, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetValueCurveAtTime(curve, ArrayLength(curve), -Infinity, 1.0, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");
   timeline.SetValueCurveAtTime(curve, ArrayLength(curve), 1.0, NaN, rv);
   is(rv, NS_ERROR_DOM_SYNTAX_ERR, "Correct error code returned");