Bug 1474808 - MediaPipeline set description even when there is no DOM Track
Early bailout was preventing mDescription from getting set in MediaPipeline::SetTransport.
MozReview-Commit-ID: HIIva7R3fLe
--- a/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
+++ b/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
@@ -1385,25 +1385,24 @@ MediaPipelineTransmit::SetDescription()
std::string description;
description = mPc + "| ";
description += mConduit->type() == MediaSessionConduit::AUDIO
? "Transmit audio["
: "Transmit video[";
if (!mDomTrack) {
description += "no track]";
- return;
+ } else {
+ nsString nsTrackId;
+ mDomTrack->GetId(nsTrackId);
+ std::string trackId(NS_ConvertUTF16toUTF8(nsTrackId).get());
+ description += trackId;
+ description += "]";
}
- nsString nsTrackId;
- mDomTrack->GetId(nsTrackId);
- std::string trackId(NS_ConvertUTF16toUTF8(nsTrackId).get());
- description += trackId;
- description += "]";
-
RUN_ON_THREAD(
mStsThread,
WrapRunnable(RefPtr<MediaPipeline>(this),
&MediaPipelineTransmit::SetDescription_s,
description),
NS_DISPATCH_NORMAL);
}