Bug 1474213 - Rename KeyframeEffect::GetPresShell to KeyframeEffect::GetRenderedPresShell. r?birtles draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Mon, 09 Jul 2018 07:16:37 +0900
changeset 815506 c66b824525e0d38d7f213cc09a3b445eaec2a119
parent 815505 89cec7d9edfd14f67778537fad3028e9436c563c
child 815507 8a52143a30aa3e40d6f56606c277f3f3608ba30a
push id115520
push userbmo:hikezoe@mozilla.com
push dateSun, 08 Jul 2018 22:24:35 +0000
reviewersbirtles
bugs1474213
milestone63.0a1
Bug 1474213 - Rename KeyframeEffect::GetPresShell to KeyframeEffect::GetRenderedPresShell. r?birtles MozReview-Commit-ID: ID87mkA2bZs
dom/animation/KeyframeEffect.cpp
dom/animation/KeyframeEffect.h
--- a/dom/animation/KeyframeEffect.cpp
+++ b/dom/animation/KeyframeEffect.cpp
@@ -1198,17 +1198,17 @@ KeyframeEffect::CanThrottleIfNotVisible(
 {
   // Unless we are newly in-effect, we can throttle the animation if the
   // animation is paint only and the target frame is out of view or the document
   // is in background tabs.
   if (!mInEffectOnLastAnimationTimingUpdate || !CanIgnoreIfNotVisible()) {
     return false;
   }
 
-  nsIPresShell* presShell = GetPresShell();
+  nsIPresShell* presShell = GetRenderedPresShell();
   if (presShell && !presShell->IsActive()) {
     return true;
   }
 
   const bool isVisibilityHidden =
     !aFrame.IsVisibleOrMayHaveVisibleDescendants();
   if ((!isVisibilityHidden || HasVisibilityChange()) &&
       !aFrame.IsScrolledOutOfView()) {
@@ -1411,17 +1411,17 @@ KeyframeEffect::GetRenderedDocument() co
 {
   if (!mTarget) {
     return nullptr;
   }
   return mTarget->mElement->GetComposedDoc();
 }
 
 nsIPresShell*
-KeyframeEffect::GetPresShell() const
+KeyframeEffect::GetRenderedPresShell() const
 {
   nsIDocument* doc = GetRenderedDocument();
   if (!doc) {
     return nullptr;
   }
   return doc->GetShell();
 }
 
--- a/dom/animation/KeyframeEffect.h
+++ b/dom/animation/KeyframeEffect.h
@@ -252,17 +252,17 @@ public:
     const nsIFrame* aFrame, AnimationPerformanceWarning::Type& aPerformanceWarning) const;
   bool HasGeometricProperties() const;
   bool AffectsGeometry() const override
   {
     return GetTarget() && HasGeometricProperties();
   }
 
   nsIDocument* GetRenderedDocument() const;
-  nsIPresShell* GetPresShell() const;
+  nsIPresShell* GetRenderedPresShell() const;
 
   // Associates a warning with the animated property on the specified frame
   // indicating why, for example, the property could not be animated on the
   // compositor. |aParams| and |aParamsLength| are optional parameters which
   // will be used to generate a localized message for devtools.
   void SetPerformanceWarning(
     nsCSSPropertyID aProperty,
     const AnimationPerformanceWarning& aWarning);