Bug 1452706 - Fix the expected arguments to be RegExps in test_format_command.js. r?yulia
MozReview-Commit-ID: 24DtFcF9o2F
--- a/devtools/server/tests/unit/test_format_command.js
+++ b/devtools/server/tests/unit/test_format_command.js
@@ -59,38 +59,43 @@ const testcases = [
},
{
input: ":screenshot \"foo b\\\"ar\"",
expectedOutput: "screenshot({\"filename\":\"foo b\\\\\\\"ar\"})"
}
];
const edgecases = [
- { input: ":", expectedError: "'' is not a valid command" },
- { input: ":invalid", expectedError: "'invalid' is not a valid command" },
- { input: ":screenshot :help", expectedError: "invalid command" },
- { input: ":screenshot --", expectedError: "invalid flag" },
+ { input: ":", expectedError: /'' is not a valid command/ },
+ { input: ":invalid", expectedError: /'invalid' is not a valid command/ },
+ { input: ":screenshot :help", expectedError: /Invalid command/ },
+ { input: ":screenshot --", expectedError: /invalid flag/ },
{
input: ":screenshot \"fo\"o bar",
- expectedError: "String contains unexpected `\"` character"
+ // XXX Bug 1473569 - this should be: /String contains unexpected `\"` character/
+ expectedError: /String does not terminate/
},
{
input: ":screenshot \"foo b\"ar",
- expectedError: "String contains unexpected `\"` character"
+ // XXX Bug 1473569 - this should be: /String contains unexpected `\"` character/
+ expectedError: /String does not terminate/
},
- { input: ": screenshot", expectedError: "'' is not a valid command" },
- { input: ":screenshot \"file name", expectedError: "String does not terminate" },
+ { input: ": screenshot", expectedError: /'' is not a valid command/ },
+ { input: ":screenshot \"file name", expectedError: /String does not terminate/ },
{
input: ":screenshot \"file name --clipboard",
- expectedError: "String does not terminate before flag \"clipboard\""
+ // XXX Bug 1473569 - this should be:
+ // /String does not terminate before flag \"clipboard\"/
+ expectedError: /String does not terminate before flag clipboard/
},
- { input: "::screenshot", expectedError: "':screenshot' is not a valid command" }
+ { input: "::screenshot", expectedError: /':screenshot' is not a valid command/ }
];
function run_test() {
testcases.forEach(testcase => {
Assert.equal(formatCommand(testcase.input), testcase.expectedOutput);
});
edgecases.forEach(testcase => {
- Assert.throws(() => formatCommand(testcase.input), testcase.expectedError);
+ Assert.throws(() => formatCommand(testcase.input), testcase.expectedError,
+ `"${testcase.input}" should throw expected error`);
});
}