Bug 1472966 - Styling tweaks for Font Editor. r=gl draft
authorRazvan Caliman <rcaliman@mozilla.com>
Tue, 03 Jul 2018 14:44:08 +0200
changeset 814076 1b6408c0cb65269ae8729eaa7183fdbfbc135e6a
parent 813581 a0e47ebc4c06e652b919dabee711fdbd6bfd31b5
child 814077 ebfbf406f0fc61b79402af791ab9cbd8b32ba2bf
push id115083
push userbmo:rcaliman@mozilla.com
push dateWed, 04 Jul 2018 12:05:55 +0000
reviewersgl
bugs1472966
milestone63.0a1
Bug 1472966 - Styling tweaks for Font Editor. r=gl MozReview-Commit-ID: 6T2IrHIHxpQ
devtools/client/inspector/fonts/components/FontPropertyValue.js
devtools/client/themes/fonts.css
--- a/devtools/client/inspector/fonts/components/FontPropertyValue.js
+++ b/devtools/client/inspector/fonts/components/FontPropertyValue.js
@@ -92,16 +92,17 @@ class FontPropertyValue extends PureComp
         title: this.props.label,
         type: "range",
       }
     );
 
     const input = dom.input(
       {
         ...defaults,
+        name: this.props.name,
         className: "font-value-input",
         type: "number",
       }
     );
 
     let unitDropdown = null;
     if (this.props.showUnit) {
       // Ensure the dropdown has the current unit type even if we don't recognize it.
--- a/devtools/client/themes/fonts.css
+++ b/devtools/client/themes/fonts.css
@@ -168,59 +168,84 @@
 }
 
 .font-instance-select:active{
   outline: none;
 }
 
 .font-value-input {
   margin-left: 10px;
+  text-align: right;
   width: 60px;
 }
 
+/* Do not use browser "invalid" state */
+.font-value-input:-moz-ui-invalid {
+  box-shadow: none;
+}
+
+/* Do not show dotted line focus outline */
+.font-value-input:-moz-focusring {
+  outline: none;
+}
+
+/* Add space between input text from number stepper */
+.font-value-input[type=number]::-moz-number-spin-box{
+  margin-left: 3px;
+}
+
+/* Do not show number stepper for font-size */
+.font-value-input[name=font-size] {
+  -moz-appearance: textfield;
+  margin-right: 5px;
+  padding-right: 5px;
+}
+
+.font-unit-select {
+  padding: 2px;
+}
+
 .font-value-slider {
   flex: 1;
   margin: 0;
   min-width: 50px;
 }
 
 /*
   The value of font-weight goes from 100 to 900 in increments of 100.
   Decorate the slider for font-weight to have 9 vertical notches using a linear gradient.
 */
 .font-value-slider[name=font-weight] {
-  --notch-size: 2px;
+  --notch-size: 3px;
   /* Draw a vertical line to get one notch per background-image instance */
   background-image: linear-gradient(90deg, var(--grey-30) var(--notch-size), transparent 0);
   /* Offset the background so the notch aligns with the center of the slider thumb */
-  background-position: 7px center;
+  background-position: 5px center;
   /* Repeat the background-image horizontally */
   background-repeat: repeat-x;
   /* Size the background to get nine visible notch instances. */
-  background-size: calc(12.5% - var(--notch-size)) 90%;
+  background-size: calc(12.5% - var(--notch-size) / 2) 7px;
 }
 
 .font-value-slider:-moz-focusring {
   outline: none;
 }
 
 .font-value-slider::-moz-focus-outer {
   border: 0;
 }
 
 .font-value-slider::-moz-range-thumb {
   background: var(--grey-50);
-  border-color: rgba(0, 0, 0, 0);
+  border: 0;
 }
+
 .font-value-slider::-moz-range-track {
   background: var(--grey-30);
-}
-
-.font-value-slider:focus::-moz-range-thumb {
-  background: var(--blue-55);
+  height: 3px;
 }
 
 /*
   Restyle a native checkbox input to look like a toggle with a "thumb".
   Build the decoration using solid shapes created with radial- and linear-gradient
   background images. Animate the position of the "thumb" using background-position.
  */
 .font-value-toggle {