Bug 1472684: Hide info bar and guides from highlighter. r?gl draft
authorDaisuke Akatsuka <dakatsuka@mozilla.com>
Wed, 04 Jul 2018 10:50:12 +0900
changeset 813885 4364fc5c138ec8f8947732d95940a1cb39509242
parent 813884 d82e5c726da254420d02f63bc671d1a3c5c5e4f2
child 813887 ccba4588f9d27c2444f75987cfb545438e4716dd
child 813938 2b115c0037b228e70fc559ca4f7ccb19f3a2535b
push id115036
push userbmo:dakatsuka@mozilla.com
push dateWed, 04 Jul 2018 01:50:57 +0000
reviewersgl
bugs1472684
milestone63.0a1
Bug 1472684: Hide info bar and guides from highlighter. r?gl MozReview-Commit-ID: AAchCYg0d61
devtools/client/inspector/animation/animation.js
devtools/client/inspector/animation/components/AnimationTarget.js
--- a/devtools/client/inspector/animation/animation.js
+++ b/devtools/client/inspector/animation/animation.js
@@ -512,17 +512,18 @@ class AnimationInspector {
    * If no node is provided, hide the box model highlighter.
    *
    * @param {NodeFront} nodeFront
    */
   async setHighlightedNode(nodeFront) {
     await this.inspector.highlighters.hideBoxModelHighlighter();
 
     if (nodeFront) {
-      await this.inspector.highlighters.showBoxModelHighlighter(nodeFront);
+      await this.inspector.highlighters.showBoxModelHighlighter(
+        nodeFront, { hideInfoBar: true, hideGuides: true });
     }
 
     this.inspector.store.dispatch(updateHighlightedNode(nodeFront));
   }
 
   /**
    * Returns simulatable animation by given parameters.
    * The returned animation is implementing Animation interface of Web Animation API.
--- a/devtools/client/inspector/animation/components/AnimationTarget.js
+++ b/devtools/client/inspector/animation/components/AnimationTarget.js
@@ -83,17 +83,18 @@ class AnimationTarget extends Component 
       await this.updateNodeFront(this.props.animation);
     }
   }
 
   async highlight() {
     await this.ensureNodeFront();
 
     if (this.state.nodeFront) {
-      this.props.onShowBoxModelHighlighterForNode(this.state.nodeFront);
+      this.props.onShowBoxModelHighlighterForNode(
+        this.state.nodeFront, { hideInfoBar: true, hideGuides: true });
     }
   }
 
   async select() {
     await this.ensureNodeFront();
 
     if (this.state.nodeFront) {
       this.props.setSelectedNode(this.state.nodeFront);