Bug 1472832 - Use notifyAll() in GeckoBackgroundThread r=droeh draft
authorJames Willcox <snorp@snorp.net>
Mon, 02 Jul 2018 17:12:02 -0500
changeset 813307 ff4d7bcb42d0151e6e3e900e4a405570ee660ef3
parent 813306 5cbda1669fbf67c449ac3d835cc1cc33fd986be4
push id114859
push userbmo:snorp@snorp.net
push dateMon, 02 Jul 2018 22:13:20 +0000
reviewersdroeh
bugs1472832
milestone63.0a1
Bug 1472832 - Use notifyAll() in GeckoBackgroundThread r=droeh Without this we deadlock if more than one thread is waiting in getHandler(). MozReview-Commit-ID: GCB7haz7Lwb
mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoBackgroundThread.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoBackgroundThread.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoBackgroundThread.java
@@ -27,17 +27,17 @@ final class GeckoBackgroundThread extend
 
     @Override
     public void run() {
         setName(LOOPER_NAME);
         Looper.prepare();
 
         synchronized (GeckoBackgroundThread.class) {
             handler = new Handler();
-            GeckoBackgroundThread.class.notify();
+            GeckoBackgroundThread.class.notifyAll();
         }
 
         if (initialRunnable != null) {
             initialRunnable.run();
             initialRunnable = null;
         }
 
         Looper.loop();