Bug 1445764 - Remove some Places special casing in eslint configurations;r=Standard8 draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Tue, 03 Jul 2018 14:26:54 -0700
changeset 813783 137d613c8729d40e45a1295b981d54889f434d96
parent 813782 ff283c5ec16470585985c3a8c9389ea79ff08c12
push id115004
push userbgrinstead@mozilla.com
push dateTue, 03 Jul 2018 21:27:14 +0000
reviewersStandard8
bugs1445764
milestone63.0a1
Bug 1445764 - Remove some Places special casing in eslint configurations;r=Standard8 MozReview-Commit-ID: BKOTaZZxo1b
tools/lint/eslint.yml
tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
--- a/tools/lint/eslint.yml
+++ b/tools/lint/eslint.yml
@@ -10,19 +10,16 @@ eslint:
         - '.eslintignore'
         - 'tools/lint/eslint/**'
         # Files that can influence global variables
         - 'browser/base/content/nsContextMenu.js'
         - 'browser/base/content/utilityOverlay.js'
         - 'browser/components/customizableui/content/panelUI.js'
         - 'browser/components/downloads/content/downloads.js'
         - 'browser/components/downloads/content/indicator.js'
-        - 'browser/components/places/content/browserPlacesViews.js'
-        - 'browser/components/places/content/controller.js'
-        - 'browser/components/places/content/treeView.js'
         - 'testing/mochitest/tests/SimpleTest/EventUtils.js'
         - 'testing/mochitest/tests/SimpleTest/MockObjects.js'
         - 'testing/mochitest/tests/SimpleTest/SimpleTest.js'
         - 'testing/mochitest/tests/SimpleTest/WindowSnapshot.js'
         - 'toolkit/components/printing/content/printUtils.js'
         - 'toolkit/components/viewsource/content/viewSourceUtils.js'
         - 'toolkit/content/contentAreaUtils.js'
         - 'toolkit/content/editMenuOverlay.js'
--- a/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
@@ -36,31 +36,22 @@ const EXTRA_SCRIPTS = [
   "toolkit/content/editMenuOverlay.js"
 ];
 
 const extraDefinitions = [
   // Via Components.utils, defineModuleGetter, defineLazyModuleGetters or
   // defineLazyScriptGetter (and map to
   // single) variable.
   {name: "XPCOMUtils", writable: false},
-  {name: "Task", writable: false},
-  {name: "PlacesUtils", writable: false},
-  {name: "PlacesUIUtils", writable: false},
-  {name: "PlacesTransactions", writable: false},
-  {name: "PlacesTreeView", writable: false},
-  {name: "PlacesInsertionPoint", writable: false},
-  {name: "PlacesController", writable: false},
-  {name: "PlacesControllerDragHelper", writable: false}
+  {name: "Task", writable: false}
 ];
 
 // Some files in global-scripts.inc need mapping to specific locations.
 const MAPPINGS = {
   "printUtils.js": "toolkit/components/printing/content/printUtils.js",
-  "browserPlacesViews.js":
-    "browser/components/places/content/browserPlacesViews.js",
   "panelUI.js": "browser/components/customizableui/content/panelUI.js",
   "viewSourceUtils.js":
     "toolkit/components/viewsource/content/viewSourceUtils.js"
 };
 
 const globalScriptsRegExp =
   /<script type=\"application\/javascript\" src=\"(.*)\"\/>|^\s*"(.*?\.js)",$/;