Bug 1471254 - Add Android package name to crash reports r=esawin draft
authorJames Willcox <snorp@snorp.net>
Mon, 02 Jul 2018 13:31:54 -0500
changeset 813203 a4e7ceea0401132bc83f1377c5b6cb7a4184b120
parent 813201 e97bd9859ca1e2f0b2f0d4a52f129721373a5a69
child 813306 5cbda1669fbf67c449ac3d835cc1cc33fd986be4
push id114820
push userbmo:snorp@snorp.net
push dateMon, 02 Jul 2018 18:36:52 +0000
reviewersesawin
bugs1471254
milestone63.0a1
Bug 1471254 - Add Android package name to crash reports r=esawin This will allow us to determine which app is crashing for crashes that come from GeckoView. I've also renamed the AndroidProcessName field to Android_ProcessName for consistency. MozReview-Commit-ID: JL1u7VVxbSx
mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashHandler.java
mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashReporterService.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashHandler.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashHandler.java
@@ -227,22 +227,21 @@ public class CrashHandler implements Thr
      * @param thread The exception thread
      * @param exc An exception
      * @return "Extras" in the from of a Bundle
      */
     protected Bundle getCrashExtras(final Thread thread, final Throwable exc) {
         final Context context = getAppContext();
         final Bundle extras = new Bundle();
         final String pkgName = getAppPackageName();
-        final String processName = getProcessName();
 
-        extras.putString("ProductName", pkgName);
         extras.putLong("CrashTime", getCrashTime());
         extras.putLong("StartupTime", getStartupTime());
-        extras.putString("AndroidProcessName", getProcessName());
+        extras.putString("Android_ProcessName", getProcessName());
+        extras.putString("Android_PackageName", pkgName);
 
         if (context != null) {
             final PackageManager pkgMgr = context.getPackageManager();
             try {
                 final PackageInfo pkgInfo = pkgMgr.getPackageInfo(pkgName, 0);
                 extras.putString("Version", pkgInfo.versionName);
                 extras.putInt("BuildID", pkgInfo.versionCode);
                 extras.putLong("InstallTime", pkgInfo.lastUpdateTime / 1000);
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashReporterService.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashReporterService.java
@@ -323,16 +323,17 @@ public class CrashReporterService extend
             sendPart(os, boundary, "Android_Manufacturer", Build.MANUFACTURER);
             sendPart(os, boundary, "Android_Model", Build.MODEL);
             sendPart(os, boundary, "Android_Board", Build.BOARD);
             sendPart(os, boundary, "Android_Brand", Build.BRAND);
             sendPart(os, boundary, "Android_Device", Build.DEVICE);
             sendPart(os, boundary, "Android_Display", Build.DISPLAY);
             sendPart(os, boundary, "Android_Fingerprint", Build.FINGERPRINT);
             sendPart(os, boundary, "Android_CPU_ABI", Build.CPU_ABI);
+            sendPart(os, boundary, "Android_PackageName", getPackageName());
             try {
                 sendPart(os, boundary, "Android_CPU_ABI2", Build.CPU_ABI2);
                 sendPart(os, boundary, "Android_Hardware", Build.HARDWARE);
             } catch (Exception ex) {
                 Log.e(LOGTAG, "Exception while sending SDK version 8 keys", ex);
             }
             sendPart(os, boundary, "Android_Version",  Build.VERSION.SDK_INT + " (" + Build.VERSION.CODENAME + ")");
             sendPart(os, boundary, PASSED_MINI_DUMP_SUCCESS_KEY, mMinidumpSucceeded ? "True" : "False");