bug 1472656 - only do DNS_TRR_COMPARE in shadow or parallel mode r?mcmanus draft
authorDaniel Stenberg <daniel@haxx.se>
Mon, 02 Jul 2018 13:04:11 +0200
changeset 813958 a4c2f63dd5443808314d494e9ccde6e5c41216fb
parent 812962 3cfc350101967376909ad3c729f9779ae0ab7a94
push id115063
push userbmo:daniel@haxx.se
push dateWed, 04 Jul 2018 08:46:20 +0000
reviewersmcmanus
bugs1472656
milestone63.0a1
bug 1472656 - only do DNS_TRR_COMPARE in shadow or parallel mode r?mcmanus MozReview-Commit-ID: 5eQb3pCNIwK
netwerk/dns/nsHostResolver.cpp
--- a/netwerk/dns/nsHostResolver.cpp
+++ b/netwerk/dns/nsHostResolver.cpp
@@ -289,17 +289,18 @@ nsHostRecord::ResolveComplete()
         } else {
             AccumulateCategorical(((mTrrDuration - mNativeDuration) > k50ms) ?
                                   Telemetry::LABELS_DNS_TRR_RACE::NativeFasterBy50 :
                                   Telemetry::LABELS_DNS_TRR_RACE::NativeFaster);
             LOG(("nsHostRecord::Complete %s Dns Race: NATIVE\n", host.get()));
         }
     }
 
-    if (mTRRUsed && mNativeUsed) {
+    if (mTRRUsed && mNativeUsed &&
+        ((mResolverMode == MODE_SHADOW) || (mResolverMode == MODE_PARALLEL))) {
         // both were used, accumulate comparative success
         AccumulateCategorical(mNativeSuccess && mTRRSuccess?
                               Telemetry::LABELS_DNS_TRR_COMPARE::BothWorked :
                               ((mNativeSuccess ? Telemetry::LABELS_DNS_TRR_COMPARE::NativeWorked :
                                 (mTRRSuccess ? Telemetry::LABELS_DNS_TRR_COMPARE::TRRWorked:
                                  Telemetry::LABELS_DNS_TRR_COMPARE::BothFailed))));
     }