Bug 1472472 - Use PlacesCommandHook.bookmarkLink instead of PlacesCommandHook.bookmarkPage in activity stream. r?mardak
MozReview-Commit-ID: EszRhVlaNky
--- a/browser/extensions/activity-stream/lib/PlacesFeed.jsm
+++ b/browser/extensions/activity-stream/lib/PlacesFeed.jsm
@@ -288,17 +288,17 @@ class PlacesFeed {
this.removeObservers();
break;
case at.BLOCK_URL: {
const {url, pocket_id} = action.data;
NewTabUtils.activityStreamLinks.blockURL({url, pocket_id});
break;
}
case at.BOOKMARK_URL:
- NewTabUtils.activityStreamLinks.addBookmark(action.data, action._target.browser);
+ NewTabUtils.activityStreamLinks.addBookmark(action.data, action._target.browser.ownerGlobal);
break;
case at.DELETE_BOOKMARK_BY_ID:
NewTabUtils.activityStreamLinks.deleteBookmark(action.data);
break;
case at.DELETE_HISTORY_URL: {
const {url, forceBlock, pocket_id} = action.data;
NewTabUtils.activityStreamLinks.deleteHistoryEntry(url);
if (forceBlock) {
--- a/toolkit/modules/NewTabUtils.jsm
+++ b/toolkit/modules/NewTabUtils.jsm
@@ -1284,24 +1284,25 @@ var ActivityStreamLinks = {
/**
* Adds a bookmark and opens up the Bookmark Dialog to show feedback that
* the bookmarking action has been successful
*
* @param {Object} aData
* aData.url The url to bookmark
* aData.title The title of the page to bookmark
- * @param {Browser} aBrowser
- * a <browser> element
+ * @param {Window} aBrowserWindow
+ * The current browser chrome window
*
* @returns {Promise} Returns a promise set to an object representing the bookmark
*/
- addBookmark(aData, aBrowser) {
+ addBookmark(aData, aBrowserWindow) {
const {url, title} = aData;
- return aBrowser.ownerGlobal.PlacesCommandHook.bookmarkPage(
+ return aBrowserWindow.PlacesCommandHook.bookmarkLink(
+ PlacesUtils.bookmarksMenuFolderId,
url,
title);
},
/**
* Removes a bookmark
*
* @param {String} aBookmarkGuid