Bug 1461204 - check the residual offset for following groups. r?kats draft
authorAlexis Beingessner <a.beingessner@gmail.com>
Wed, 27 Jun 2018 16:59:29 -0400
changeset 811580 b72bb4f25974e9e4a630289dfdc776b60b19c4b5
parent 808416 257c191e7903523a1132e04460a0b2460d950809
child 813755 95100ba05e15ddd827cc5f2bde961b80a75f0428
push id114356
push userbmo:a.beingessner@gmail.com
push dateWed, 27 Jun 2018 21:05:13 +0000
reviewerskats
bugs1461204
milestone62.0a1
Bug 1461204 - check the residual offset for following groups. r?kats This was missed when the residual offset was added; it's correctly checked elsewhere MozReview-Commit-ID: 44N5vDWLBIo
gfx/layers/wr/WebRenderCommandBuilder.cpp
--- a/gfx/layers/wr/WebRenderCommandBuilder.cpp
+++ b/gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ -943,17 +943,18 @@ Grouper::ConstructGroups(WebRenderComman
 
       // Initialize groupData->mFollowingGroup
       // TODO: compute the group bounds post-grouping, so that they can be
       // tighter for just the sublist that made it into this group.
       // We want to ensure the tight bounds are still clipped by area
       // that we're building the display list for.
       if (!groupData->mFollowingGroup.mGroupBounds.IsEqualEdges(currentGroup->mGroupBounds) ||
           groupData->mFollowingGroup.mScale != currentGroup->mScale ||
-          groupData->mFollowingGroup.mAppUnitsPerDevPixel != currentGroup->mAppUnitsPerDevPixel) {
+          groupData->mFollowingGroup.mAppUnitsPerDevPixel != currentGroup->mAppUnitsPerDevPixel ||
+          groupData->mFollowingGroup.mResidualOffset != currentGroup->mResidualOffset) {
         if (groupData->mFollowingGroup.mAppUnitsPerDevPixel != currentGroup->mAppUnitsPerDevPixel) {
           GP("app unit change following: %d %d\n", groupData->mFollowingGroup.mAppUnitsPerDevPixel, currentGroup->mAppUnitsPerDevPixel);
         }
         // The group changed size
         GP("Inner group size change\n");
         groupData->mFollowingGroup.ClearItems();
         if (groupData->mFollowingGroup.mKey) {
           MOZ_RELEASE_ASSERT(groupData->mFollowingGroup.mInvalidRect.IsEmpty());