Bug 1470779: label History and Bookmarks sidebar containers for accessibility. r?mak draft
authorJames Teh <jteh@mozilla.com>
Wed, 27 Jun 2018 10:53:03 +1000
changeset 811154 597deccad46263c11241109bc0e8a34ce6d3c4e9
parent 810379 6e8e861540e6d8c85c73ab7b2afa1f027fb3750c
push id114207
push userbmo:jteh@mozilla.com
push dateWed, 27 Jun 2018 01:07:44 +0000
reviewersmak
bugs1470779
milestone63.0a1
Bug 1470779: label History and Bookmarks sidebar containers for accessibility. r?mak Without this, accessibility reports the chrome:// URL of the page element as the label, which is ugly for screen reader users in particular. MozReview-Commit-ID: AIInSb79YcN
browser/components/places/content/bookmarksSidebar.xul
browser/components/places/content/historySidebar.xul
--- a/browser/components/places/content/bookmarksSidebar.xul
+++ b/browser/components/places/content/bookmarksSidebar.xul
@@ -7,23 +7,26 @@
 <?xml-stylesheet href="chrome://global/skin/" type="text/css"?>
 <?xml-stylesheet href="chrome://browser/skin/places/places.css"?>
 
 <!DOCTYPE page [
 <!ENTITY % placesDTD SYSTEM "chrome://browser/locale/places/places.dtd">
 %placesDTD;
 <!ENTITY % editMenuDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
 %editMenuDTD;
+<!ENTITY % browserDTD SYSTEM "chrome://browser/locale/browser.dtd">
+%browserDTD;
 ]>
 
 <page id="bookmarksPanel"
       xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
       xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
       onload="init();"
-      onunload="PlacesUIUtils.setMouseoverURL('', window);">
+      onunload="PlacesUIUtils.setMouseoverURL('', window);"
+      aria-label="&bookmarksButton.label;">
 
   <script type="application/javascript"
           src="chrome://browser/content/places/bookmarksSidebar.js"/>
   <script type="application/javascript"
           src="chrome://global/content/globalOverlay.js"/>
   <script type="application/javascript"
           src="chrome://browser/content/utilityOverlay.js"/>
   <script type="application/javascript"><![CDATA[
--- a/browser/components/places/content/historySidebar.xul
+++ b/browser/components/places/content/historySidebar.xul
@@ -7,23 +7,26 @@
 <?xml-stylesheet href="chrome://global/skin/" type="text/css"?>
 <?xml-stylesheet href="chrome://browser/skin/places/places.css"?>
 
 <!DOCTYPE page [
 <!ENTITY % placesDTD SYSTEM "chrome://browser/locale/places/places.dtd">
 %placesDTD;
 <!ENTITY % editMenuDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
 %editMenuDTD;
+<!ENTITY % browserDTD SYSTEM "chrome://browser/locale/browser.dtd">
+%browserDTD;
 ]>
 
 <page id="history-panel"
       orient="vertical"
       xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
       onload="HistorySidebarInit();"
-      onunload="PlacesUIUtils.setMouseoverURL('', window);">
+      onunload="PlacesUIUtils.setMouseoverURL('', window);"
+      aria-label="&historyButton.label;">
 
   <script type="application/javascript"
           src="chrome://browser/content/places/historySidebar.js"/>
   <script type="application/javascript"
           src="chrome://global/content/globalOverlay.js"/>
   <script type="application/javascript"
           src="chrome://browser/content/utilityOverlay.js"/>
   <script type="application/javascript"><![CDATA[