Bug 1471285 - [Clang-Tidy 5.0.1] Checker misc-suspicious-missing-comma has faulty test case. r?janx draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 26 Jun 2018 17:44:44 +0100
changeset 810865 32956c951519625c0ec891dbc08f20933a8cd6c8
parent 810823 348090c6b5c421c67b9dccc48742b54a854d6d0e
push id114139
push userbmo:bpostelnicu@mozilla.com
push dateTue, 26 Jun 2018 16:45:32 +0000
reviewersjanx
bugs1471285
milestone63.0a1
Bug 1471285 - [Clang-Tidy 5.0.1] Checker misc-suspicious-missing-comma has faulty test case. r?janx MozReview-Commit-ID: 2COIi47WQBO
tools/clang-tidy/test/misc-suspicious-missing-comma.cpp
tools/clang-tidy/test/misc-suspicious-missing-comma.json
--- a/tools/clang-tidy/test/misc-suspicious-missing-comma.cpp
+++ b/tools/clang-tidy/test/misc-suspicious-missing-comma.cpp
@@ -1,9 +1,9 @@
-
-// misc-suspicious-missing-comma
-const char* software[] = {
-  "Firefox",
-  "Rust"   // There is a missing comma here.
-  "Thunderbird",
-  "kinto"
+const char* Cartoons[] = {
+  "Bugs Bunny",
+  "Homer Simpson",
+  "Mickey Mouse",
+  "Bart Simpson",
+  "Charlie Brown"  // There is a missing comma here.
+  "Fred Flintstone",
+  "Popeye",
 };
-
--- a/tools/clang-tidy/test/misc-suspicious-missing-comma.json
+++ b/tools/clang-tidy/test/misc-suspicious-missing-comma.json
@@ -1,1 +1,1 @@
-"[]"
\ No newline at end of file
+"[[\"warning\", \"suspicious string literal, probably missing a comma\", \"misc-suspicious-missing-comma\"]]"
\ No newline at end of file