Bug 1470393 - Implement workaround for squashed favicon in the bookmarking panel. r?mak draft
authorDão Gottwald <dao@mozilla.com>
Tue, 26 Jun 2018 13:14:00 +0200
changeset 810738 f35731cbef50d42749f9f80cb637864aa410759d
parent 810379 6e8e861540e6d8c85c73ab7b2afa1f027fb3750c
push id114080
push userdgottwald@mozilla.com
push dateTue, 26 Jun 2018 11:14:27 +0000
reviewersmak
bugs1470393
milestone63.0a1
Bug 1470393 - Implement workaround for squashed favicon in the bookmarking panel. r?mak MozReview-Commit-ID: IjbeUoTgxWO
browser/base/content/browser.xul
browser/themes/shared/places/editBookmarkPanel.inc.css
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -229,19 +229,19 @@
            ignorekeys="true"
            hidden="true"
            tabspecific="true"
            onpopupshown="StarUI.panelShown(event);"
            aria-labelledby="editBookmarkPanelTitle">
       <box class="panel-header">
         <label id="editBookmarkPanelTitle"/>
       </box>
-      <box>
+      <html:div id="editBookmarkPanelFaviconContainer">
         <html:img id="editBookmarkPanelFavicon"/>
-      </box>
+      </html:div>
       <box id="editBookmarkPanelImage"/>
 #include ../../components/places/content/editBookmarkPanel.inc.xul
       <hbox id="editBookmarkPanelBottomButtons" pack="end">
 #ifndef XP_UNIX
         <button id="editBookmarkPanelDoneButton"
                 class="editBookmarkPanelBottomButton"
                 label="&editBookmark.done.label;"
                 default="true"
--- a/browser/themes/shared/places/editBookmarkPanel.inc.css
+++ b/browser/themes/shared/places/editBookmarkPanel.inc.css
@@ -3,25 +3,28 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 %endif
 
 #editBookmarkPanel > .panel-arrowcontainer > .panel-arrowcontent {
   padding: 0;
 }
 
+html|div#editBookmarkPanelFaviconContainer {
+  display: flex;
+}
+
 html|img#editBookmarkPanelFavicon[src] {
   box-sizing: content-box;
   width: 32px;
   height: 32px;
   padding: 5px;
   background-color: #F9F9FA;
   box-shadow: inset 0 0 0 1px rgba(0,0,0,.1);
   border-radius: 6px;
-  position: relative;
   margin-top: 10px;
   margin-inline-start: 10px;
   margin-bottom: -52px; /* margin-top + paddings + height */
 }
 
 #editBookmarkPanelImage {
   border-bottom: 1px solid var(--panel-separator-color);
   height: 150px;