Bug 1470965: Fix refcount sanity in nsIPrincipal.addonPolicy getter. r?mixedpuppy draft
authorKris Maglione <maglione.k@gmail.com>
Tue, 26 Jun 2018 00:19:46 -0700
changeset 810595 883fa5db7bb39084fe9e1e18edcd0227c5a44722
parent 810583 56d6546b2c573c94d88edc43fcba3cb89c186045
push id114045
push usermaglione.k@gmail.com
push dateTue, 26 Jun 2018 07:20:08 +0000
reviewersmixedpuppy
bugs1470965
milestone63.0a1
Bug 1470965: Fix refcount sanity in nsIPrincipal.addonPolicy getter. r?mixedpuppy MozReview-Commit-ID: KuDN3joKi7S
caps/BasePrincipal.cpp
--- a/caps/BasePrincipal.cpp
+++ b/caps/BasePrincipal.cpp
@@ -331,17 +331,18 @@ BasePrincipal::GetIsInIsolatedMozBrowser
 {
   *aIsInIsolatedMozBrowserElement = IsInIsolatedMozBrowserElement();
   return NS_OK;
 }
 
 nsresult
 BasePrincipal::GetAddonPolicy(nsISupports** aResult)
 {
-  *aResult = AddonPolicy();
+  RefPtr<extensions::WebExtensionPolicy> policy(AddonPolicy());
+  policy.forget(aResult);
   return NS_OK;
 }
 
 extensions::WebExtensionPolicy*
 BasePrincipal::AddonPolicy()
 {
   if (Is<ContentPrincipal>()) {
     return As<ContentPrincipal>()->AddonPolicy();