Bug 1470870 - Load "menu.css" as a document stylesheet. r=bgrins draft
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Thu, 05 Jul 2018 15:08:06 +0100
changeset 814496 7d0fe549b57a0938fbb8090e5a17336a7bc1d369
parent 814424 ec01dc489dfe656dc6501d75f1b023c0c1f60065
child 814535 95d827262f7ee6727dc5b4ab7dd81bfa7bc2a802
push id115236
push userpaolo.mozmail@amadzone.org
push dateThu, 05 Jul 2018 14:28:32 +0000
reviewersbgrins
bugs1470870
milestone63.0a1
Bug 1470870 - Load "menu.css" as a document stylesheet. r=bgrins The specificity of some Windows rules is reduced to match other platforms. MozReview-Commit-ID: 28oUf7b6vCW
toolkit/content/components.css
toolkit/content/widgets.css
toolkit/themes/shared/in-content/common.inc.css
toolkit/themes/windows/global/menu.css
--- a/toolkit/content/components.css
+++ b/toolkit/content/components.css
@@ -8,11 +8,10 @@
    ==
    == These are loaded as UA syles, but eventually they will become
    == document styles in "widgets.css". See bug 1463820 for details.
    ==
    ======================================================================= */
 
 @import url("chrome://global/skin/dropmarker.css");
 @import url("chrome://global/skin/groupbox.css");
-@import url("chrome://global/skin/menu.css");
 @import url("chrome://global/skin/toolbar.css");
 @import url("chrome://global/skin/splitter.css");
--- a/toolkit/content/widgets.css
+++ b/toolkit/content/widgets.css
@@ -1,9 +1,10 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* ===== widgets.css =====================================================
    == Styles ported from XBL <resources>, loaded by "global.css".
    ======================================================================= */
 
+@import url("chrome://global/skin/menu.css");
 @import url("chrome://global/skin/menulist.css");
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -103,17 +103,17 @@ xul|groupbox {
   margin: 0;
   padding: 0;
 }
 
 xul|groupbox > xul|caption {
   padding: 4px 0;
 }
 
-xul|groupbox xul|label:not(.menu-accel):not(.menu-text):not(.menulist-label):not(.indent):not(.learnMore):not(.tail-with-learn-more),
+xul|groupbox xul|label:not(.menu-accel):not(.menu-iconic-accel):not(.menu-text):not(.menu-iconic-text):not(.menulist-label):not(.indent):not(.learnMore):not(.tail-with-learn-more),
 xul|groupbox xul|description {
   /* !important needed to override toolkit !important rule */
   margin-inline-start: 0 !important;
   margin-inline-end: 0 !important;
 }
 
 /* tabpanels and tabs */
 
--- a/toolkit/themes/windows/global/menu.css
+++ b/toolkit/themes/windows/global/menu.css
@@ -85,18 +85,18 @@ menucaption > .menu-iconic-text {
   min-width: 1.45em;
 }
 
 .menu-iconic-icon {
   width: 16px;
   height: 16px;
 }
 
-menu.menu-iconic > .menu-iconic-left,
-menuitem.menuitem-iconic > .menu-iconic-left {
+.menu-iconic > .menu-iconic-left,
+.menuitem-iconic > .menu-iconic-left {
   -moz-appearance: menuimage;
   padding-top: 2px;
 }
 
 /* ..... menu arrow box ..... */
 
 .menu-right {
   -moz-appearance: menuarrow;