Bug 1470861: Trivially simplify some code in nsWebBrowserFind. r?mats draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 25 Jun 2018 12:03:32 +0200
changeset 810137 6e220ab7cd493f8cc20b3e5b73b6c31fc617d2cf
parent 810136 9e656d327d9f8eb72756da15ca47b78e78e65976
child 810138 050eeb60b4abd1128825a8ae8838cd82af748186
push id113905
push userbmo:emilio@crisal.io
push dateMon, 25 Jun 2018 12:31:46 +0000
reviewersmats
bugs1470861
milestone62.0a1
Bug 1470861: Trivially simplify some code in nsWebBrowserFind. r?mats MozReview-Commit-ID: AaLVbxRbaCU
toolkit/components/find/nsWebBrowserFind.cpp
--- a/toolkit/components/find/nsWebBrowserFind.cpp
+++ b/toolkit/components/find/nsWebBrowserFind.cpp
@@ -715,25 +715,17 @@ nsWebBrowserFind::SearchInFrame(nsPIDOMW
 
   RefPtr<nsRange> searchRange = new nsRange(theDoc);
   RefPtr<nsRange> startPt = new nsRange(theDoc);
   RefPtr<nsRange> endPt = new nsRange(theDoc);
   NS_ENSURE_ARG_POINTER(endPt);
 
   RefPtr<nsRange> foundRange;
 
-  // If !aWrapping, search from selection to end
-  if (!aWrapping)
-    rv = GetSearchLimits(searchRange, startPt, endPt, theDoc, sel, false);
-
-  // If aWrapping, search the part of the starting frame
-  // up to the point where we left off.
-  else
-    rv = GetSearchLimits(searchRange, startPt, endPt, theDoc, sel, true);
-
+  rv = GetSearchLimits(searchRange, startPt, endPt, theDoc, sel, aWrapping);
   NS_ENSURE_SUCCESS(rv, rv);
 
   rv = find->Find(mSearchString.get(), searchRange, startPt, endPt,
                   getter_AddRefs(foundRange));
 
   if (NS_SUCCEEDED(rv) && foundRange) {
     *aDidFind = true;
     sel->RemoveAllRanges(IgnoreErrors());