Bug 1464722 part 3 - Fix rtl computation in ComputeScrollbarParams. r?spohl draft
authorXidorn Quan <me@upsuper.org>
Mon, 25 Jun 2018 09:43:05 +1000
changeset 810028 caa6062380454fcbd9cf18f2993fa789155d4912
parent 810011 888a6ec0b056ab1dc3a18483a2929e67caacfd5c
child 810029 e935bc0f51a1e94d22ce8a34359e7e39f31e2be9
push id113864
push userxquan@mozilla.com
push dateMon, 25 Jun 2018 00:30:18 +0000
reviewersspohl
bugs1464722
milestone62.0a1
Bug 1464722 part 3 - Fix rtl computation in ComputeScrollbarParams. r?spohl MozReview-Commit-ID: GVAfPYS34a9
widget/cocoa/nsNativeThemeCocoa.mm
--- a/widget/cocoa/nsNativeThemeCocoa.mm
+++ b/widget/cocoa/nsNativeThemeCocoa.mm
@@ -2699,17 +2699,17 @@ nsNativeThemeCocoa::ComputeScrollbarPara
 {
   ScrollbarParams params;
   params.overlay = nsLookAndFeel::UseOverlayScrollbars();
   params.rolledOver = IsParentScrollbarRolledOver(aFrame);
   nsIFrame* scrollbarFrame = GetParentScrollbarFrame(aFrame);
   params.small =
     (scrollbarFrame &&
      scrollbarFrame->StyleDisplay()->mAppearance == NS_THEME_SCROLLBAR_SMALL);
-  params.rtl = aFrame->StyleVisibility()->mDirection == NS_STYLE_DIRECTION_RTL;
+  params.rtl = IsFrameRTL(aFrame);
   params.horizontal = aIsHorizontal;
   params.onDarkBackground = IsDarkBackground(aFrame);
   return params;
 }
 
 void
 nsNativeThemeCocoa::DrawScrollbarThumb(CGContextRef cgContext,
                                        const CGRect& inBoxRect,