Bug 1465046 - Remove depricated function call in unit-nsinstall tests. r=whimboo draft
authorAkshay Chiwhane <achiwhane@gmail.com>
Sun, 24 Jun 2018 14:06:29 -0400
changeset 810002 62b714c528ed39013feafb844fb8e62458baea85
parent 807572 f0476f981af2ead225567073dfe909cdb2f72624
push id113856
push userbmo:achiwhane@gmail.com
push dateSun, 24 Jun 2018 18:06:59 +0000
reviewerswhimboo
bugs1465046
milestone62.0a1
Bug 1465046 - Remove depricated function call in unit-nsinstall tests. r=whimboo MozReview-Commit-ID: DFAMmN8CFiH
config/tests/unit-nsinstall.py
--- a/config/tests/unit-nsinstall.py
+++ b/config/tests/unit-nsinstall.py
@@ -163,17 +163,17 @@ class TestNsinstall(unittest.TestCase):
             testdir = self.mkdirs(u"\u4241\u1D04\u1414")
             # We don't use subprocess because it can't handle Unicode on
             # Windows <http://bugs.python.org/issue1759845>. mozprocess calls
             # CreateProcessW directly so it's perfect.
             p = processhandler.ProcessHandlerMixin([sys.executable,
                                                     NSINSTALL_PATH,
                                                     testfile, testdir])
             p.run()
-            rv = p.waitForFinish()
+            rv = p.wait()
 
             self.assertEqual(rv, 0)
             destfile = os.path.join(testdir, filename)
             self.assert_(os.path.isfile(destfile))
 
     # TODO: implement -R, -l, -L and test them!