Bug 1435688 - Part 3 - Remove "listitem-iconic" from the profile selection dialog. r=bgrins draft
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Sat, 23 Jun 2018 21:18:16 +0100
changeset 809896 e2f9add0789d0fa5282a636e5d43f02882651d86
parent 809895 d103bae10272030d6a1f78d8a679ab69f72ee5c6
child 809897 1ea5e6f940f80404cef724e14f0ebf75f86eb03c
push id113840
push userpaolo.mozmail@amadzone.org
push dateSat, 23 Jun 2018 20:25:01 +0000
reviewersbgrins
bugs1435688
milestone62.0a1
Bug 1435688 - Part 3 - Remove "listitem-iconic" from the profile selection dialog. r=bgrins MozReview-Commit-ID: 8IWXdyP83rM
toolkit/profile/content/profileSelection.js
toolkit/themes/linux/mozapps/jar.mn
toolkit/themes/linux/mozapps/profile/profileicon.png
toolkit/themes/osx/mozapps/jar.mn
toolkit/themes/osx/mozapps/profile/profileSelection.css
toolkit/themes/osx/mozapps/profile/profileicon-selected.png
toolkit/themes/osx/mozapps/profile/profileicon.png
toolkit/themes/windows/mozapps/jar.mn
toolkit/themes/windows/mozapps/profile/profileSelection.css
toolkit/themes/windows/mozapps/profile/profileicon.png
--- a/toolkit/profile/content/profileSelection.js
+++ b/toolkit/profile/content/profileSelection.js
@@ -35,17 +35,16 @@ function startup() {
     while (profileList.hasMoreElements()) {
       var profile = profileList.getNext().QueryInterface(I.nsIToolkitProfile);
 
       var listitem = profilesElement.appendItem(profile.name, "");
 
       var tooltiptext =
         gProfileManagerBundle.getFormattedString("profileTooltip", [profile.name, profile.rootDir.path]);
       listitem.setAttribute("tooltiptext", tooltiptext);
-      listitem.setAttribute("class", "listitem-iconic");
       listitem.profile = profile;
       try {
         if (profile === gProfileService.selectedProfile) {
           setTimeout(function(a) {
             profilesElement.ensureElementIsVisible(a);
             profilesElement.selectItem(a);
           }, 0, listitem);
         }
@@ -154,17 +153,16 @@ function CreateProfileWizard() {
 function CreateProfile(aProfile) {
   var profilesElement = document.getElementById("profiles");
 
   var listitem = profilesElement.appendItem(aProfile.name, "");
 
   var tooltiptext =
     gProfileManagerBundle.getFormattedString("profileTooltip", [aProfile.name, aProfile.rootDir.path]);
   listitem.setAttribute("tooltiptext", tooltiptext);
-  listitem.setAttribute("class", "listitem-iconic");
   listitem.profile = aProfile;
 
   profilesElement.ensureElementIsVisible(listitem);
   profilesElement.selectItem(listitem);
 }
 
 // rename the selected profile
 function RenameProfile() {
--- a/toolkit/themes/linux/mozapps/jar.mn
+++ b/toolkit/themes/linux/mozapps/jar.mn
@@ -1,10 +1,9 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 toolkit.jar:
 #include ../../shared/mozapps.inc.mn
 * skin/classic/mozapps/extensions/extensions.css           (extensions/extensions.css)
   skin/classic/mozapps/extensions/heart.png                (extensions/heart.png)
-  skin/classic/mozapps/profile/profileicon.png             (profile/profileicon.png)
   skin/classic/mozapps/update/updates.css                  (update/updates.css)
deleted file mode 100644
index 2d247db361e8a79898fc8d892d2d939edcb77322..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
--- a/toolkit/themes/osx/mozapps/jar.mn
+++ b/toolkit/themes/osx/mozapps/jar.mn
@@ -11,15 +11,13 @@ toolkit.jar:
   skin/classic/mozapps/extensions/rating-not-won.png              (extensions/rating-not-won.png)
   skin/classic/mozapps/extensions/cancel.png                      (extensions/cancel.png)
   skin/classic/mozapps/extensions/toolbarbutton-dropmarker.png    (extensions/toolbarbutton-dropmarker.png)
   skin/classic/mozapps/extensions/heart.png                       (extensions/heart.png)
 * skin/classic/mozapps/extensions/extensions.css                  (extensions/extensions.css)
   skin/classic/mozapps/extensions/eula.css                        (extensions/eula.css)
   skin/classic/mozapps/extensions/blocklist.css                   (extensions/blocklist.css)
   skin/classic/mozapps/plugins/pluginHelp-16.png                  (plugins/pluginHelp-16.png)
-  skin/classic/mozapps/profile/profileicon.png                    (profile/profileicon.png)
   skin/classic/mozapps/profile/profileSelection.css               (profile/profileSelection.css)
-  skin/classic/mozapps/profile/profileicon-selected.png           (profile/profileicon-selected.png)
   skin/classic/mozapps/update/buttons.png                         (update/buttons.png)
 * skin/classic/mozapps/update/updates.css                         (update/updates.css)
   skin/classic/mozapps/xpinstall/xpinstallConfirm.css             (extensions/xpinstallConfirm.css)
   skin/classic/mozapps/handling/handling.css                      (handling/handling.css)
--- a/toolkit/themes/osx/mozapps/profile/profileSelection.css
+++ b/toolkit/themes/osx/mozapps/profile/profileSelection.css
@@ -2,28 +2,15 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 
 @import url("chrome://global/skin/global.css");
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
-#profiles > listitem {
-  list-style-image: url("chrome://mozapps/skin/profile/profileicon.png");
-}
-
-#profiles:focus > listitem[selected="true"] {
-  list-style-image: url("chrome://mozapps/skin/profile/profileicon-selected.png");
-}
-
-#profiles > listitem image {
-  width: 16px;
-  height: 16px;
-}
-
 box#managebuttons > button {
   min-width: 8em;
 }
 
 #managebuttons {
   padding-top: 1em;
 }
deleted file mode 100644
index e43c5bdfa3490ebb06ade61471f116ceae2cc23e..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 4b4efef571038be0db5f6618fabc0741e1e67910..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
--- a/toolkit/themes/windows/mozapps/jar.mn
+++ b/toolkit/themes/windows/mozapps/jar.mn
@@ -1,10 +1,9 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 toolkit.jar:
 #include ../../shared/mozapps.inc.mn
 * skin/classic/mozapps/extensions/extensions.css             (extensions/extensions.css)
   skin/classic/mozapps/extensions/heart.png                  (extensions/heart.png)
-  skin/classic/mozapps/profile/profileicon.png               (profile/profileicon.png)
   skin/classic/mozapps/update/updates.css                    (update/updates.css)
--- a/toolkit/themes/windows/mozapps/profile/profileSelection.css
+++ b/toolkit/themes/windows/mozapps/profile/profileSelection.css
@@ -2,24 +2,15 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 
 @import url("chrome://global/skin/global.css");
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
-#profiles > listitem {
-  list-style-image: url("chrome://mozapps/skin/profile/profileicon.png");
-}
-
-#profiles > listitem image {
-  width: 16px;
-  height: 16px;
-}
-
 box#managebuttons > button {
   min-width: 8em;
 }
 
 #managebuttons {
   padding-top: 1em;
 }
deleted file mode 100644
index 45a92e8921789d71e7bd8328a349d61fe660b087..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001