Bug 1427998 - The toast message is correct when deleting a bookmark from bookmarks panel. r?cliu@mozilla.com draft
authorErica Wright <ewright@mozilla.com>
Thu, 21 Jun 2018 17:28:28 -0400
changeset 809329 596a1f730a5529fcaf6338a6b39ce2ee0ab8f2b2
parent 809312 96399298b72f804bc5ce8d7dbf2039d108acd49b
push id113645
push userbmo:ewright@mozilla.com
push dateThu, 21 Jun 2018 21:29:46 +0000
reviewerscliu
bugs1427998
milestone62.0a1
Bug 1427998 - The toast message is correct when deleting a bookmark from bookmarks panel. r?cliu@mozilla.com MozReview-Commit-ID: F5jmyuQTPT1
mobile/android/base/java/org/mozilla/gecko/home/HomeFragment.java
mobile/android/base/locales/en-US/android_strings.dtd
--- a/mobile/android/base/java/org/mozilla/gecko/home/HomeFragment.java
+++ b/mobile/android/base/java/org/mozilla/gecko/home/HomeFragment.java
@@ -551,16 +551,18 @@ public abstract class HomeFragment exten
         public void onPostExecute(Void result) {
             final Activity activity = activityWeakReference.get();
             if (activity == null || activity.isFinishing()) {
                 return;
             }
             final int message;
             if (info.isFolder) {
                 message = R.string.folder_removed;
+            } else if (info.itemType.name() == "BOOKMARKS") {
+                message = R.string.bookmark_removed;
             } else {
                 message = R.string.page_removed;
             }
             SnackbarBuilder.builder(activity)
                     .message(message)
                     .duration(Snackbar.LENGTH_LONG)
                     .buildAndShow();
         }
--- a/mobile/android/base/locales/en-US/android_strings.dtd
+++ b/mobile/android/base/locales/en-US/android_strings.dtd
@@ -541,17 +541,17 @@
 
 <!-- Localization note (pref_compact_tabs): Label for setting that controls whether 1 wide column or
      2 narrower (compact) columns are used for tabs in the tabs tray in portrait mode on phones. -->
 <!ENTITY pref_compact_tabs "Compact tabs">
 <!ENTITY pref_compact_tabs_summary2 "Arrange tabs in two columns in portrait mode">
 
 <!-- Localization note (page_removed): This string appears in a toast message when
      any page is removed from about:home. This includes pages that are in history,
-     bookmarks, or reading list. -->
+     or reading list. -->
 <!ENTITY page_removed "Page removed">
 <!ENTITY folder_removed "Folder removed">
 
 <!ENTITY bookmark_edit_title "Edit Bookmark">
 <!ENTITY bookmark_edit_folder_title "Edit Folder">
 <!ENTITY bookmark_edit_name "Name">
 <!ENTITY bookmark_edit_location "Location">
 <!ENTITY bookmark_edit_keyword "Keyword">