Bug 1469108: Fix some pre-existing style issues / unnecessary default arguments. r?smaug draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Fri, 15 Jun 2018 19:15:22 -0700
changeset 807917 1c5e0a39b2246110e047d0771cc0820fdaa0882d
parent 807916 0fe90fbf779970f5ea9c3bf78b9b309edc5a497c
child 807918 d71d0e5f7b5b99049cba43b0462a356f9de80e3e
push id113242
push userbmo:emilio@crisal.io
push dateSat, 16 Jun 2018 02:39:16 +0000
reviewerssmaug
bugs1469108
milestone62.0a1
Bug 1469108: Fix some pre-existing style issues / unnecessary default arguments. r?smaug MozReview-Commit-ID: 3oogRy66cwx
dom/base/DirectionalityUtils.cpp
--- a/dom/base/DirectionalityUtils.cpp
+++ b/dom/base/DirectionalityUtils.cpp
@@ -366,17 +366,17 @@ GetDirectionFromText(const nsTextFragmen
  * http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#the-directionality
  *
  * @param[in] changedNode If we call this method because the content of a text
  *            node is about to change, pass in the changed node, so that we
  *            know not to return it
  * @return the text node containing the character that determined the direction
  */
 static nsTextNode*
-WalkDescendantsSetDirectionFromText(Element* aElement, bool aNotify = true,
+WalkDescendantsSetDirectionFromText(Element* aElement, bool aNotify,
                                     nsINode* aChangedNode = nullptr)
 {
   MOZ_ASSERT(aElement, "Must have an element");
   MOZ_ASSERT(aElement->HasDirAuto(), "Element must have dir=auto");
 
   if (DoesNotParticipateInAutoDirection(aElement)) {
     return nullptr;
   }
@@ -777,18 +777,19 @@ WalkDescendantsClearAncestorDirAuto(Elem
       continue;
     }
 
     child->ClearAncestorHasDirAuto();
     child = child->GetNextNode(aElement);
   }
 }
 
-void SetAncestorDirectionIfAuto(nsTextNode* aTextNode, Directionality aDir,
-                                bool aNotify = true)
+void
+SetAncestorDirectionIfAuto(nsTextNode* aTextNode, Directionality aDir,
+                           bool aNotify = true)
 {
   MOZ_ASSERT(aTextNode->NodeType() == nsINode::TEXT_NODE,
              "Must be a text node");
 
   Element* parent = aTextNode->GetParentElement();
   while (parent && parent->NodeOrAncestorHasDirAuto()) {
     if (DoesNotParticipateInAutoDirection(parent) || parent->HasFixedDir()) {
       break;
@@ -991,17 +992,17 @@ OnSetDirAttr(Element* aElement, const ns
     }
     SetDirectionalityOnDescendants(aElement,
                                    RecomputeDirectionality(aElement, aNotify),
                                    aNotify);
   }
 }
 
 void
-SetDirOnBind(mozilla::dom::Element* aElement, nsIContent* aParent)
+SetDirOnBind(Element* aElement, nsIContent* aParent)
 {
   // Set the AncestorHasDirAuto flag, unless this element shouldn't affect
   // ancestors that have dir=auto
   if (!DoesNotParticipateInAutoDirection(aElement) &&
       !aElement->IsHTMLElement(nsGkAtoms::bdi) &&
       aParent && aParent->NodeOrAncestorHasDirAuto()) {
     aElement->SetAncestorHasDirAuto();
 
@@ -1029,17 +1030,18 @@ SetDirOnBind(mozilla::dom::Element* aEle
 
   if (!aElement->HasDirAuto()) {
     // if the element doesn't have dir=auto, set its own directionality from
     // the dir attribute or by inheriting from its ancestors.
     RecomputeDirectionality(aElement, false);
   }
 }
 
-void ResetDir(mozilla::dom::Element* aElement)
+void
+ResetDir(Element* aElement)
 {
   if (aElement->HasDirAutoSet()) {
     nsTextNode* setByNode =
       static_cast<nsTextNode*>(aElement->GetProperty(nsGkAtoms::dirAutoSetBy));
     nsTextNodeDirectionalityMap::RemoveElementFromMap(setByNode, aElement);
   }
 
   if (!aElement->HasDirAuto()) {