Bug 1468989 - Fix isTextInMessageText for longStrings; r=Honza. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Fri, 15 Jun 2018 11:33:32 -0700
changeset 810077 6d3bafc4a0238302f4c6b874b1e52db88df1b87c
parent 810076 bb758d7d793358f8f45ad0a1befcafb73c6d733e
push id113882
push userbmo:nchevobbe@mozilla.com
push dateMon, 25 Jun 2018 06:51:24 +0000
reviewersHonza
bugs1468989
milestone62.0a1
Bug 1468989 - Fix isTextInMessageText for longStrings; r=Honza. MozReview-Commit-ID: 7jINj8Etmpv
devtools/client/webconsole/reducers/messages.js
--- a/devtools/client/webconsole/reducers/messages.js
+++ b/devtools/client/webconsole/reducers/messages.js
@@ -842,17 +842,25 @@ function isTextInStackTrace(text, stackt
 /**
 * Returns true if given text is included in `messageText` field.
 */
 function isTextInMessageText(text, messageText) {
   if (!messageText) {
     return false;
   }
 
-  return messageText.toLocaleLowerCase().includes(text.toLocaleLowerCase());
+  if (typeof messageText === "string") {
+    return messageText.toLocaleLowerCase().includes(text.toLocaleLowerCase());
+  }
+
+  if (messageText.type === "longString") {
+    return messageText.initial.toLocaleLowerCase().includes(text.toLocaleLowerCase());
+  }
+
+  return true;
 }
 
 /**
 * Returns true if given text is included in notes.
 */
 function isTextInNotes(text, notes) {
   if (!Array.isArray(notes)) {
     return false;