Bug 1468989 - Add a longString exception in filter tests; r=Honza. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Fri, 15 Jun 2018 11:27:55 -0700
changeset 810076 bb758d7d793358f8f45ad0a1befcafb73c6d733e
parent 810075 d7b9078789cb9b93b97bc4670e6183eb1646f418
child 810077 6d3bafc4a0238302f4c6b874b1e52db88df1b87c
push id113882
push userbmo:nchevobbe@mozilla.com
push dateMon, 25 Jun 2018 06:51:24 +0000
reviewersHonza
bugs1468989
milestone62.0a1
Bug 1468989 - Add a longString exception in filter tests; r=Honza. This way we make sure we handle them as they should be. MozReview-Commit-ID: AQILE8NqbSE
devtools/client/webconsole/test/store/filters.test.js
--- a/devtools/client/webconsole/test/store/filters.test.js
+++ b/devtools/client/webconsole/test/store/filters.test.js
@@ -74,17 +74,17 @@ describe("Filtering", () => {
       const messages = getVisibleMessages(store.getState());
       expect(messages.length).toEqual(numUnfilterableMessages + 1);
     });
 
     it("filters error messages", () => {
       store.dispatch(actions.filterToggle(FILTERS.ERROR));
 
       const messages = getVisibleMessages(store.getState());
-      expect(messages.length).toEqual(numUnfilterableMessages + 3);
+      expect(messages.length).toEqual(numUnfilterableMessages + 4);
     });
 
     it("filters css messages", () => {
       const message = stubPreparedMessages.get(
         "Unknown property ‘such-unknown-property’.  Declaration dropped."
       );
       store.dispatch(messagesAdd([message]));
 
@@ -367,16 +367,17 @@ function prepareBaseStore() {
     "console.warn('danger, will robinson!')",
     "console.log(undefined)",
     "console.count('bar')",
     "console.log('鼬')",
     // Evaluation Result - never filtered
     "new Date(0)",
     // PageError
     "ReferenceError: asdf is not defined",
+    "TypeError longString message",
     "console.group('bar')",
     "console.debug('debug message');",
     "console.info('info message');",
     "console.error('error message');",
     "console.table(['red', 'green', 'blue']);",
     "console.assert(false, {message: 'foobar'})",
   ]);