Bug 1457689 - Remove NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN; r=bz draft
authorKyle Machulis <kyle@nonpolynomial.com>
Fri, 08 Jun 2018 15:52:53 -0700
changeset 806314 ea8700db22ae55ec88df73bc9adacc0d9d3a0a61
parent 806313 66868e2222e9d35de275619782461bd82f9f6599
push id112853
push userbmo:kyle@nonpolynomial.com
push dateFri, 08 Jun 2018 22:57:57 +0000
reviewersbz
bugs1457689
milestone62.0a1
Bug 1457689 - Remove NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN; r=bz After fixing the document.domain exceptions to conform to the html spec, NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN is no longer used, and can be removed. MozReview-Commit-ID: 9CwrUSGy2K3
dom/base/domerr.msg
xpcom/base/ErrorList.py
--- a/dom/base/domerr.msg
+++ b/dom/base/domerr.msg
@@ -88,17 +88,16 @@ DOM4_MSG_DEF(UnknownError, "The operatio
 DOM_MSG_DEF(NS_ERROR_DOM_SECMAN_ERR, "Unable to obtain security manager")
 DOM_MSG_DEF(NS_ERROR_DOM_WRONG_TYPE_ERR, "Object is of wrong type")
 DOM_MSG_DEF(NS_ERROR_DOM_NOT_OBJECT_ERR, "Parameter is not an object")
 DOM_MSG_DEF(NS_ERROR_DOM_NOT_XPC_OBJECT_ERR, "Parameter is not a XPConnect object")
 DOM_MSG_DEF(NS_ERROR_DOM_NOT_NUMBER_ERR, "Parameter is not a number")
 DOM_MSG_DEF(NS_ERROR_DOM_NOT_BOOLEAN_ERR, "Parameter is not a boolean")
 DOM_MSG_DEF(NS_ERROR_DOM_NOT_FUNCTION_ERR, "Parameter is not a Function")
 DOM_MSG_DEF(NS_ERROR_DOM_TOO_FEW_PARAMETERS_ERR, "Too few parameters to method")
-DOM_MSG_DEF(NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN, "Illegal document.domain value")
 DOM_MSG_DEF(NS_ERROR_DOM_PROP_ACCESS_DENIED, "Access to property denied")
 DOM_MSG_DEF(NS_ERROR_DOM_XPCONNECT_ACCESS_DENIED, "Access to XPConnect service denied")
 DOM_MSG_DEF(NS_ERROR_DOM_BAD_URI, "Access to restricted URI denied")
 DOM_MSG_DEF(NS_ERROR_DOM_RETVAL_UNDEFINED, "Return value is undefined")
 DOM_MSG_DEF(NS_ERROR_DOM_QUOTA_REACHED, "Persistent storage maximum size reached")
 
 DOM4_MSG_DEF(NotFoundError, "File was not found", NS_ERROR_DOM_FILE_NOT_FOUND_ERR)
 DOM4_MSG_DEF(NotReadableError, "File could not be read", NS_ERROR_DOM_FILE_NOT_READABLE_ERR)
--- a/xpcom/base/ErrorList.py
+++ b/xpcom/base/ErrorList.py
@@ -630,17 +630,16 @@ with modules["DOM"]:
     errors["NS_ERROR_DOM_SECMAN_ERR"] = FAILURE(1001)
     errors["NS_ERROR_DOM_WRONG_TYPE_ERR"] = FAILURE(1002)
     errors["NS_ERROR_DOM_NOT_OBJECT_ERR"] = FAILURE(1003)
     errors["NS_ERROR_DOM_NOT_XPC_OBJECT_ERR"] = FAILURE(1004)
     errors["NS_ERROR_DOM_NOT_NUMBER_ERR"] = FAILURE(1005)
     errors["NS_ERROR_DOM_NOT_BOOLEAN_ERR"] = FAILURE(1006)
     errors["NS_ERROR_DOM_NOT_FUNCTION_ERR"] = FAILURE(1007)
     errors["NS_ERROR_DOM_TOO_FEW_PARAMETERS_ERR"] = FAILURE(1008)
-    errors["NS_ERROR_DOM_BAD_DOCUMENT_DOMAIN"] = FAILURE(1009)
     errors["NS_ERROR_DOM_PROP_ACCESS_DENIED"] = FAILURE(1010)
     errors["NS_ERROR_DOM_XPCONNECT_ACCESS_DENIED"] = FAILURE(1011)
     errors["NS_ERROR_DOM_BAD_URI"] = FAILURE(1012)
     errors["NS_ERROR_DOM_RETVAL_UNDEFINED"] = FAILURE(1013)
     errors["NS_ERROR_DOM_QUOTA_REACHED"] = FAILURE(1014)
 
     # A way to represent uncatchable exceptions
     errors["NS_ERROR_UNCATCHABLE_EXCEPTION"] = FAILURE(1015)