Bug 1419297 - Don't clear mCustomElements in FreeInnerObjects. r=smaug draft
authorBlake Kaplan <mrbkap@gmail.com>
Thu, 07 Jun 2018 17:02:32 -0700
changeset 805853 0907f240d4c8a7896161755bc5bf68b2b322d5ec
parent 805852 e4d0d1ec8446d114bbe79399e64636f25771c9ac
push id112778
push userbmo:mrbkap@mozilla.com
push dateFri, 08 Jun 2018 16:04:17 +0000
reviewerssmaug
bugs1419297
milestone62.0a1
Bug 1419297 - Don't clear mCustomElements in FreeInnerObjects. r=smaug The cycle collecter should make sure the cycle here gets collected and clearing it causes us to fail a wpt test. MozReview-Commit-ID: 4kL69h0AR9q
dom/base/nsGlobalWindowInner.cpp
testing/web-platform/meta/custom-elements/custom-element-registry/per-global.html.ini
--- a/dom/base/nsGlobalWindowInner.cpp
+++ b/dom/base/nsGlobalWindowInner.cpp
@@ -1177,17 +1177,16 @@ nsGlobalWindowInner::FreeInnerObjects()
   mChromeEventHandler = nullptr;
 
   if (mListenerManager) {
     mListenerManager->Disconnect();
     mListenerManager = nullptr;
   }
 
   mHistory = nullptr;
-  mCustomElements = nullptr;
 
   if (mNavigator) {
     mNavigator->OnNavigation();
     mNavigator->Invalidate();
     mNavigator = nullptr;
   }
 
   mScreen = nullptr;
deleted file mode 100644
--- a/testing/web-platform/meta/custom-elements/custom-element-registry/per-global.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[per-global.html]
-  [Discarding the browsing context must not change window.customElements]
-    expected: FAIL
-