Bug 1354232 - Don't store the result of update_expected, r=maja_zf draft
authorJames Graham <james@hoppipolla.co.uk>
Thu, 07 Jun 2018 11:40:56 +0100
changeset 805847 c99735628a868fea2611062d333ce6bd6f7cab7d
parent 805846 ca4efcc59766e6c336ca457491fe8ff71caee153
child 805848 4e899e1b1a7cd46f8b25ac713b522e401d161976
push id112776
push userbmo:james@hoppipolla.co.uk
push dateFri, 08 Jun 2018 15:53:57 +0000
reviewersmaja_zf
bugs1354232
milestone62.0a1
Bug 1354232 - Don't store the result of update_expected, r=maja_zf The needs_human feature never worked well and is unused. MozReview-Commit-ID: KemDBXjHPV8
testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py
@@ -13,33 +13,31 @@ class GetUpdatePropertyList(Step):
             state.config, state.product)
         state.property_order = property_order + state.extra_properties
         state.boolean_properties = boolean_properties
 
 
 class UpdateExpected(Step):
     """Do the metadata update on the local checkout"""
 
-    provides = ["needs_human"]
-
     def create(self, state):
         if state.sync_tree is not None:
             sync_root = state.sync_tree.root
         else:
             sync_root = None
 
-        state.needs_human = metadata.update_expected(state.paths,
-                                                     state.serve_root,
-                                                     state.run_log,
-                                                     rev_old=None,
-                                                     ignore_existing=state.ignore_existing,
-                                                     sync_root=sync_root,
-                                                     property_order=state.property_order,
-                                                     boolean_properties=state.boolean_properties,
-                                                     stability=state.stability)
+        metadata.update_expected(state.paths,
+                                 state.serve_root,
+                                 state.run_log,
+                                 rev_old=None,
+                                 ignore_existing=state.ignore_existing,
+                                 sync_root=sync_root,
+                                 property_order=state.property_order,
+                                 boolean_properties=state.boolean_properties,
+                                 stability=state.stability)
 
 
 class CreateMetadataPatch(Step):
     """Create a patch/commit for the metadata checkout"""
 
     def create(self, state):
         if not state.patch:
             return