Bug 1465063 - Add await before assertRejects draft
authorRob Wu <rob@robwu.nl>
Fri, 08 Jun 2018 11:31:05 +0200
changeset 805804 d47bb3dbf7d477409905ebd7d6d703cc08caa1b3
parent 805551 ea21bf3e665d10066b6dce39873de9b353a12e57
child 805805 bff7f19d26e5389e7d1aa3d18c1dcff072f6ec2b
child 805830 a855bb85ae3b68e3ceee6b29dced4191ac0ebf30
child 805884 d5ccbff0e13d5d6c6789b7f5fe70c50026cd51e2
push id112765
push userbmo:rob@robwu.nl
push dateFri, 08 Jun 2018 14:15:02 +0000
bugs1465063
milestone62.0a1
Bug 1465063 - Add await before assertRejects Wait for the promise resolution before moving to the next line in the tests. MozReview-Commit-ID: Ldeiwj9vCzn
toolkit/components/extensions/test/mochitest/test_ext_cookies_first_party.html
--- a/toolkit/components/extensions/test/mochitest/test_ext_cookies_first_party.html
+++ b/toolkit/components/extensions/test/mochitest/test_ext_cookies_first_party.html
@@ -93,57 +93,61 @@ async function background() {
     browser.test.sendMessage("test_fpi_disabled");
   };
 
   // Test when FPI is enabled.
   const test_fpi_enabled = async () => {
     let cookie, cookies;
 
     // set
-    browser.test.assertRejects(browser.cookies.set({url, name: "foo3", value: "bar3"}),
-                               expectedError,
-                               "set: FPI on, w/o firstPartyDomain, rejection");
+    await browser.test.assertRejects(
+      browser.cookies.set({url, name: "foo3", value: "bar3"}),
+      expectedError,
+      "set: FPI on, w/o firstPartyDomain, rejection");
     cookie = await browser.cookies.set({url, name: "foo4", value: "bar4", firstPartyDomain});
     assertExpectedCookies([
       {name: "foo4", value: "bar4", firstPartyDomain},
     ], [cookie], "set: FPI on, w/ firstPartyDomain, FP cookie");
 
     // get
-    browser.test.assertRejects(browser.cookies.get({url, name: "foo3"}),
-                               expectedError,
-                               "get: FPI on, w/o firstPartyDomain, rejection");
+    await browser.test.assertRejects(
+      browser.cookies.get({url, name: "foo3"}),
+      expectedError,
+      "get: FPI on, w/o firstPartyDomain, rejection");
     cookie = await browser.cookies.get({url, name: "foo4", firstPartyDomain});
     assertExpectedCookies([
       {name: "foo4", value: "bar4", firstPartyDomain},
     ], [cookie], "get: FPI on, w/ firstPartyDomain, FP cookie");
     cookie = await browser.cookies.get({url, name: "foo2", firstPartyDomain});
     assertExpectedCookies([
       {name: "foo2", value: "bar2", firstPartyDomain},
     ], [cookie], "get: FPI on, w/ firstPartyDomain, FP cookie (set when FPI off)");
 
     // getAll
-    browser.test.assertRejects(browser.cookies.getAll({}),
-                               expectedError,
-                               "getAll: FPI on, w/o firstPartyDomain, rejection");
+    await browser.test.assertRejects(
+      browser.cookies.getAll({}),
+      expectedError,
+      "getAll: FPI on, w/o firstPartyDomain, rejection");
     cookies = await browser.cookies.getAll({firstPartyDomain: null});
     assertExpectedCookies([
       {name: "foo1", value: "bar1", firstPartyDomain: ""},
       {name: "foo2", value: "bar2", firstPartyDomain},
       {name: "foo4", value: "bar4", firstPartyDomain},
     ], cookies, "getAll: FPI on, w/ null firstPartyDomain, all cookies");
     cookies = await browser.cookies.getAll({firstPartyDomain});
     assertExpectedCookies([
       {name: "foo2", value: "bar2", firstPartyDomain},
       {name: "foo4", value: "bar4", firstPartyDomain},
     ], cookies, "getAll: FPI on, w/ firstPartyDomain, FP cookies");
 
     // remove
-    browser.test.assertRejects(browser.cookies.remove({url, name: "foo3"}),
-                               expectedError,
-                               "remove: FPI on, w/o firstPartyDomain, rejection");
+    await browser.test.assertRejects(
+      browser.cookies.remove({url, name: "foo3"}),
+      expectedError,
+      "remove: FPI on, w/o firstPartyDomain, rejection");
     cookie = await browser.cookies.remove({url, name: "foo4", firstPartyDomain});
     assertExpectedCookies([
       {url, name: "foo4", firstPartyDomain},
     ], [cookie], "remove: FPI on, w/ firstPartyDomain, FP cookie");
     cookie = await browser.cookies.remove({url, name: "foo2", firstPartyDomain});
     assertExpectedCookies([
       {url, name: "foo2", firstPartyDomain},
     ], [cookie], "remove: FPI on, w/ firstPartyDomain, FP cookie (set when FPI off)");