Bug 1467232 - Ensure ping explanation is formatted correctly. r?dexter draft
authorJan-Erik Rediger <jrediger@mozilla.com>
Thu, 07 Jun 2018 13:01:51 +0200
changeset 805156 fdca87fedcceb59322c988fe9a6acf74d8a71e9b
parent 805155 ccff21ce728c36a33e0eba02c43e4b59f4ff0b21
push id112581
push userbmo:jrediger@mozilla.com
push dateThu, 07 Jun 2018 11:07:11 +0000
reviewersdexter
bugs1467232
milestone62.0a1
Bug 1467232 - Ensure ping explanation is formatted correctly. r?dexter The "pingDetails" explanation takes only 2 arguments: a link and the name of the ping to be displayed. MozReview-Commit-ID: CxLnHb73YGu
toolkit/content/aboutTelemetry.js
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -322,17 +322,17 @@ var PingPicker = {
       let pingTypeText = this._getSelectedPingType();
       controls.classList.remove("hidden");
       pingType.textContent = pingTypeText;
 
       // Change home page text.
       pingName = bundle.formatStringFromName("namedPing", [pingName, pingTypeText], 2);
       pingNameSpan.textContent = pingName;
       let explanation = bundle.GetStringFromName("pingDetails");
-      fragment = BrowserUtils.getLocalizedFragment(document, explanation, pingLink, pingNameSpan, pingTypeText);
+      fragment = BrowserUtils.getLocalizedFragment(document, explanation, pingLink, pingNameSpan);
     } else {
       // Change sidebar heading text.
       controls.classList.add("hidden");
       pingType.textContent = bundle.GetStringFromName("currentPingSidebar");
 
       // Change home page text.
       pingNameSpan.textContent = pingName;
       let explanation = bundle.GetStringFromName("pingDetailsCurrent");