Bug 1467232 - Clear the explanation text first, before adding any changed text. r?dexter draft
authorJan-Erik Rediger <jrediger@mozilla.com>
Thu, 07 Jun 2018 13:01:09 +0200
changeset 805155 ccff21ce728c36a33e0eba02c43e4b59f4ff0b21
parent 805154 ddeb39eaf68c984601f7d66589c8c1e07ad73408
child 805156 fdca87fedcceb59322c988fe9a6acf74d8a71e9b
push id112581
push userbmo:jrediger@mozilla.com
push dateThu, 07 Jun 2018 11:07:11 +0000
reviewersdexter
bugs1467232
milestone62.0a1
Bug 1467232 - Clear the explanation text first, before adding any changed text. r?dexter MozReview-Commit-ID: Po12SIQdZm
toolkit/content/aboutTelemetry.js
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -335,16 +335,17 @@ var PingPicker = {
 
       // Change home page text.
       pingNameSpan.textContent = pingName;
       let explanation = bundle.GetStringFromName("pingDetailsCurrent");
       fragment = BrowserUtils.getLocalizedFragment(document, explanation, pingLink, pingNameSpan);
     }
 
     let pingExplanation = document.getElementById("ping-explanation");
+    removeAllChildNodes(pingExplanation);
     pingExplanation.appendChild(fragment);
     pingExplanation.querySelector(".change-ping").addEventListener("click", (ev) => {
       document.getElementById("ping-picker").classList.remove("hidden");
       ev.stopPropagation();
     });
 
     GenericSubsection.deleteAllSubSections();
   },