Bug 1440421 part 1. Ignore activity-stream and node_modules for linting. r=ahal draft
authorEd Lee <edilee@mozilla.com>
Wed, 06 Jun 2018 10:32:43 -0700
changeset 805284 baf7e6db4c5bb245960b2c3d2ab2542520e1347c
parent 805204 199a085199815cc99daa658956a7c9436e1d436b
child 805285 b11c6bd342c11696de8cdbbbe24ef3034df251a5
push id112620
push userbmo:edilee@mozilla.com
push dateThu, 07 Jun 2018 16:24:33 +0000
reviewersahal
bugs1440421
milestone62.0a1
Bug 1440421 part 1. Ignore activity-stream and node_modules for linting. r=ahal MozReview-Commit-ID: EEua2y790cW
.eslintignore
.flake8
tools/lint/cpp-virtual-final.yml
--- a/.eslintignore
+++ b/.eslintignore
@@ -84,20 +84,18 @@ browser/components/translation/cld2/**
 # their own lint rules currently.
 browser/extensions/followonsearch/**
 browser/extensions/screenshots/**
 browser/extensions/pdfjs/content/build**
 browser/extensions/pdfjs/content/web**
 # generated or library files in pocket
 browser/extensions/pocket/content/panels/js/tmpl.js
 browser/extensions/pocket/content/panels/js/vendor/**
-# generated or library files in activity-stream
-browser/extensions/activity-stream/data/content/activity-stream.bundle.js
-browser/extensions/activity-stream/test/**
-browser/extensions/activity-stream/vendor/**
+# Activity Stream has incompatible eslintrc. `npm run lint` from its directory
+browser/extensions/activity-stream/**
 # The only file in browser/locales/ is pre-processed.
 browser/locales/**
 # imported from chromium
 browser/extensions/mortar/**
 # Generated data files
 browser/extensions/formautofill/phonenumberutils/PhoneNumberMetaData.jsm
 
 # devtools/ exclusions
--- a/.flake8
+++ b/.flake8
@@ -1,11 +1,12 @@
 [flake8]
 # See http://pep8.readthedocs.io/en/latest/intro.html#configuration
 ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741
 max-line-length = 99
 exclude =
     browser/extensions/mortar/ppapi/,
     build/pymake/,
+    node_modules,
     security/nss/,
     testing/mochitest/pywebsocket,
     tools/lint/test/files,
 
--- a/tools/lint/cpp-virtual-final.yml
+++ b/tools/lint/cpp-virtual-final.yml
@@ -1,16 +1,17 @@
 ---
 cpp-virtual-final:
     description: "Virtual function declarations should specify only one of
                   `virtual`, `final`, or `override`"
     level: warning
     include: ['.']
     exclude:
         # Third-party code with cpp-virtual-final warnings:
+        - '**/node_modules'
         - gfx/angle
         - gfx/skia
         - media/webrtc/trunk
         - security/sandbox/chromium
     extensions: ['cpp', 'h', 'mm']
     type: regex
     #
     # This lint warns about: