Bug 1467117 - remove unneeded sort() of devtools definitions;r=daisuke draft
authorJulian Descottes <jdescottes@mozilla.com>
Wed, 06 Jun 2018 16:03:44 +0200
changeset 804713 bf26ed09cb9def1f9c5fd6a3bc40968e4ce4dffc
parent 804582 715e3f81f67c5fb9f9810fd80690b429888ae86e
push id112447
push userjdescottes@mozilla.com
push dateWed, 06 Jun 2018 14:04:10 +0000
reviewersdaisuke
bugs1467117
milestone62.0a1
Bug 1467117 - remove unneeded sort() of devtools definitions;r=daisuke MozReview-Commit-ID: JxZX4lRSasv
devtools/client/framework/toolbox-tabs-order-manager.js
--- a/devtools/client/framework/toolbox-tabs-order-manager.js
+++ b/devtools/client/framework/toolbox-tabs-order-manager.js
@@ -154,26 +154,16 @@ class ToolboxTabsOrderManager {
     this.dragTarget = null;
     this.toolboxContainerElement = null;
     this.toolboxTabsElement = null;
   }
 }
 
 function sortPanelDefinitions(definitions) {
   const pref = Services.prefs.getCharPref(PREFERENCE_NAME, "");
-
-  if (!pref) {
-    definitions.sort(definition => {
-      return -1 * (definition.ordinal == undefined || definition.ordinal < 0
-        ? Number.MAX_VALUE
-        : definition.ordinal
-      );
-    });
-  }
-
   const toolIds = pref.split(",");
 
   return definitions.sort((a, b) => {
     let orderA = toolIds.indexOf(a.extensionId || a.id);
     let orderB = toolIds.indexOf(b.extensionId || b.id);
     orderA = orderA < 0 ? Number.MAX_VALUE : orderA;
     orderB = orderB < 0 ? Number.MAX_VALUE : orderB;
     return orderA - orderB;