Bug 1467117 - remove unneeded sort() of devtools definitions;r=daisuke
MozReview-Commit-ID: JxZX4lRSasv
--- a/devtools/client/framework/toolbox-tabs-order-manager.js
+++ b/devtools/client/framework/toolbox-tabs-order-manager.js
@@ -154,26 +154,16 @@ class ToolboxTabsOrderManager {
this.dragTarget = null;
this.toolboxContainerElement = null;
this.toolboxTabsElement = null;
}
}
function sortPanelDefinitions(definitions) {
const pref = Services.prefs.getCharPref(PREFERENCE_NAME, "");
-
- if (!pref) {
- definitions.sort(definition => {
- return -1 * (definition.ordinal == undefined || definition.ordinal < 0
- ? Number.MAX_VALUE
- : definition.ordinal
- );
- });
- }
-
const toolIds = pref.split(",");
return definitions.sort((a, b) => {
let orderA = toolIds.indexOf(a.extensionId || a.id);
let orderB = toolIds.indexOf(b.extensionId || b.id);
orderA = orderA < 0 ? Number.MAX_VALUE : orderA;
orderB = orderB < 0 ? Number.MAX_VALUE : orderB;
return orderA - orderB;