Bug 1467112 - Use listener instead of javascript: URL to conform to CSP. r?Gijs draft
authorKartikaya Gupta <kgupta@mozilla.com>
Wed, 06 Jun 2018 09:59:11 -0400
changeset 804711 c4c67abdf8d10b3167f569bb819a6c11d238c912
parent 804157 752465b44c793318cef36df46ca5ff00c3d8854a
push id112445
push userkgupta@mozilla.com
push dateWed, 06 Jun 2018 13:59:30 +0000
reviewersGijs
bugs1467112
milestone62.0a1
Bug 1467112 - Use listener instead of javascript: URL to conform to CSP. r?Gijs MozReview-Commit-ID: GewbkYeHTOy
toolkit/components/aboutcheckerboard/content/aboutCheckerboard.js
--- a/toolkit/components/aboutcheckerboard/content/aboutCheckerboard.js
+++ b/toolkit/components/aboutcheckerboard/content/aboutCheckerboard.js
@@ -11,17 +11,19 @@ var reports;
 function onLoad() {
   trace = document.getElementById("trace");
   service = new CheckerboardReportService();
   updateEnabled();
   reports = service.getReports();
   for (var i = 0; i < reports.length; i++) {
     let text = "Severity " + reports[i].severity + " at " + new Date(reports[i].timestamp).toString();
     let link = document.createElement("a");
-    link.href = "javascript:showReport(" + i + ")";
+    link.href = "#";
+    let index = i; // for capturing in the lambda
+    link.addEventListener('click', function() { showReport(index); return false; });
     link.textContent = text;
     let bullet = document.createElement("li");
     bullet.appendChild(link);
     document.getElementById(reports[i].reason).appendChild(bullet);
   }
 }
 
 function updateEnabled() {