Bug 1466963: Fix a typo. r?xidorn draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Tue, 05 Jun 2018 20:11:04 +0200
changeset 804466 208ed4fb712f24e04013b250db860b1b45b56b8e
parent 804465 84c88618dbb139e1101f47ba424dedf3feec3730
child 804467 f714a8062c5740e2d5701e2cc33db0eb293ac6e9
push id112373
push userbmo:emilio@crisal.io
push dateTue, 05 Jun 2018 22:12:13 +0000
reviewersxidorn
bugs1466963
milestone62.0a1
Bug 1466963: Fix a typo. r?xidorn Nobody looks at the result from parsing, but this is the right thing to return. MozReview-Commit-ID: 9P5VARiPIAk
servo/components/style/properties/declaration_block.rs
--- a/servo/components/style/properties/declaration_block.rs
+++ b/servo/components/style/properties/declaration_block.rs
@@ -517,17 +517,17 @@ impl PropertyDeclarationBlock {
                     continue;
                 }
 
                 let important = self.declarations_importance[i];
                 // For declarations from parsing, non-important declarations
                 // shouldn't override existing important one.
                 if important && !importance.important() &&
                     matches!(source, DeclarationSource::Parsing) {
-                    return true;
+                    return false;
                 }
 
                 if matches!(source, DeclarationSource::Parsing) {
                     // As a compatibility hack, specially on Android,
                     // don't allow to override a prefixed webkit display
                     // value with an unprefixed version from parsing
                     // code.
                     //