Bug 1464096 - 5. Allow key events when there is no View; r=me draft
authorJim Chen <nchen@mozilla.com>
Tue, 05 Jun 2018 17:49:01 -0400
changeset 804396 b8344ac27299449346821e0b359c34a469b59736
parent 804395 6de4b7ef1106e0a8457e2e62fc025acad9d40f0b
child 804397 b0d6155e6a597ea5b4e99070f038a24bae17ed87
push id112368
push userbmo:nchen@mozilla.com
push dateTue, 05 Jun 2018 21:49:45 +0000
reviewersme
bugs1464096
milestone62.0a1
Bug 1464096 - 5. Allow key events when there is no View; r=me Allow key events to pass through to Gecko when there is no text input View. MozReview-Commit-ID: E7O8Igi24H8
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoEditable.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoEditable.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoEditable.java
@@ -866,21 +866,17 @@ import android.view.inputmethod.EditorIn
                               " : " + Integer.toHexString(rangeForeColor) +
                               " : " + Integer.toHexString(rangeBackColor));
             }
         } while (rangeStart < composingEnd);
     }
 
     @Override // SessionTextInput.EditableClient
     public void sendKeyEvent(final @Nullable View view, final int action, @NonNull KeyEvent event) {
-        final Editable editable = getEditable();
-        if (editable == null) {
-            return;
-        }
-
+        final Editable editable = mProxy;
         final KeyListener keyListener = TextKeyListener.getInstance();
         event = translateKey(event.getKeyCode(), event);
 
         // We only let TextKeyListener do UI things on the UI thread.
         final View v = ThreadUtils.isOnUiThread() ? view : null;
         final int keyCode = event.getKeyCode();
         final boolean handled;