Bug 1466299 - Remove some self-move declarations to remove some warnings r?froydnj draft
authorSylvestre Ledru <sledru@mozilla.com>
Sat, 02 Jun 2018 08:35:56 +0200
changeset 803223 2484bd1b3f4536e79a68f964c553a4211639a791
parent 803222 8c926373039374cd1a47d92215e9efb4d5557983
child 803779 63da666055c9c43776fde1b25fe780dfdd5f3249
push id112048
push usersledru@mozilla.com
push dateSat, 02 Jun 2018 06:36:44 +0000
reviewersfroydnj
bugs1466299
milestone62.0a1
Bug 1466299 - Remove some self-move declarations to remove some warnings r?froydnj MozReview-Commit-ID: AuxWfBXcJl
xpcom/tests/gtest/TestPLDHash.cpp
xpcom/tests/gtest/TestTArray.cpp
--- a/xpcom/tests/gtest/TestPLDHash.cpp
+++ b/xpcom/tests/gtest/TestPLDHash.cpp
@@ -192,18 +192,16 @@ static const PLDHashTableOps trivialOps 
 
 TEST(PLDHashTableTest, MoveSemantics)
 {
   PLDHashTable t1(&trivialOps, sizeof(PLDHashEntryStub));
   t1.Add((const void*)88);
   PLDHashTable t2(&trivialOps, sizeof(PLDHashEntryStub));
   t2.Add((const void*)99);
 
-  t1 = std::move(t1);   // self-move
-
   t1 = std::move(t2);   // empty overwritten with empty
 
   PLDHashTable t3(&trivialOps, sizeof(PLDHashEntryStub));
   PLDHashTable t4(&trivialOps, sizeof(PLDHashEntryStub));
   t3.Add((const void*)88);
 
   t3 = std::move(t4);   // non-empty overwritten with empty
 
--- a/xpcom/tests/gtest/TestTArray.cpp
+++ b/xpcom/tests/gtest/TestTArray.cpp
@@ -133,18 +133,16 @@ TEST(TArray, Assign)
 
 TEST(TArray, AssignmentOperatorSelfAssignment)
 {
   nsTArray<int> array;
   array = DummyArray();
 
   array = *&array;
   ASSERT_EQ(DummyArray(), array);
-  array = std::move(array);
-  ASSERT_EQ(DummyArray(), array);
 }
 
 TEST(TArray, CopyOverlappingForwards)
 {
   const size_t rangeLength = 8;
   const size_t initialLength = 2 * rangeLength;
   uint32_t destructionCounters[initialLength];
   nsTArray<Movable> array;