Bug 1465497 - Stop setting a color on hovered checkboxes and radio buttons. r?jaws draft
authorDão Gottwald <dao@mozilla.com>
Fri, 01 Jun 2018 18:46:40 +0200
changeset 802930 ef7e7c7122b909621e21d1e95c2a90c78867a058
parent 802711 9900cebb1f9000bd05731ba67736b7c51f7eb812
push id111993
push userdgottwald@mozilla.com
push dateFri, 01 Jun 2018 16:47:06 +0000
reviewersjaws
bugs1465497
milestone62.0a1
Bug 1465497 - Stop setting a color on hovered checkboxes and radio buttons. r?jaws Gtk checkboxes and radio buttons used to render a solid background on hover and so we also set a text color for that state. Apparently we're not getting that background anymore. MozReview-Commit-ID: 7c5dbWroRbP
toolkit/themes/linux/global/checkbox.css
toolkit/themes/linux/global/in-content/common.css
toolkit/themes/linux/global/radio.css
--- a/toolkit/themes/linux/global/checkbox.css
+++ b/toolkit/themes/linux/global/checkbox.css
@@ -44,13 +44,8 @@ checkbox[disabled="true"] {
 
 /* ::::: checkmark image ::::: */
 
 .checkbox-check {
   -moz-appearance: checkbox;
   margin: 2px;
 }
 
-checkbox:not([disabled="true"]):hover {
-  color: -moz-buttonhovertext;
-  text-shadow: none;
-}
-
--- a/toolkit/themes/linux/global/in-content/common.css
+++ b/toolkit/themes/linux/global/in-content/common.css
@@ -59,23 +59,16 @@ xul|*.radio-check[selected] {
   background-color: -moz-dialog;
   fill: -moz-dialogText;
 }
 
 xul|*.radio-label-box {
   -moz-appearance: none;
 }
 
-/* Override OS-theme-based color to make it visible
-   on dark color themes. */
-xul|radio:not([disabled="true"]):hover,
-xul|checkbox:not([disabled="true"]):hover {
-  color: var(--in-content-text-color);
-}
-
 xul|*.numberbox-input-box {
   -moz-appearance: none;
   border-width: 0;
 }
 
 xul|menulist:-moz-focusring > xul|*.menulist-label-box,
 html|input[type="checkbox"]:-moz-focusring + html|label:before {
   outline: 1px dotted;
--- a/toolkit/themes/linux/global/radio.css
+++ b/toolkit/themes/linux/global/radio.css
@@ -11,20 +11,16 @@
 /* ::::: radio ::::: */
 
 radio {
   -moz-appearance: radio-container;
   -moz-box-align: center;
   margin: 2px 4px;
 }
 
-radio:hover {
-  color: -moz-buttonhovertext;
-}
-
 .radio-check {
   -moz-appearance: radio;
   margin: 2px;
 }
 
 .radio-label-box {
   -moz-appearance: radio-label;
 }