Bug 1465585: Don't error on pessimizing-move and self-move, for now. r?froydnj draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 31 May 2018 01:52:37 +0200
changeset 802164 ff22ce701b50c70b73d6f3c10a4fde4d03fdb631
parent 802163 9751e7a344c88ab4317b26aa3bf03b85c5786be1
push id111843
push userbmo:emilio@crisal.io
push dateThu, 31 May 2018 15:24:36 +0000
reviewersfroydnj
bugs1465585
milestone62.0a1
Bug 1465585: Don't error on pessimizing-move and self-move, for now. r?froydnj MozReview-Commit-ID: FzoqidPSCaV
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -81,16 +81,22 @@ check_and_add_gcc_warning('-Wstring-conv
 
 # we inline 'new' and 'delete' in mozalloc
 check_and_add_gcc_warning('-Wno-inline-new-delete', cxx_compiler)
 
 # Prevent the following GCC warnings from being treated as errors:
 # too many false positives
 check_and_add_gcc_warning('-Wno-error=maybe-uninitialized')
 
+# Turned on by -Wall, but needs changes to be turned into an error
+# (bug 1465060).
+check_and_add_gcc_warning('-Wno-error=pessimizing-move')
+# This one is probably easier, it's only triggered by tests.
+check_and_add_gcc_warning('-Wno-error=self-move')
+
 # we don't want our builds held hostage when a platform-specific API
 # becomes deprecated.
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')
 
 # false positives depending on optimization
 check_and_add_gcc_warning('-Wno-error=array-bounds')
 
 # can't get rid of those PGO warnings