Bug 1458375 - Talos tests that use TalosPowersContent.goQuitApplication(); shouldn't close their windows. r?rwood
goQuitApplication does the work of closing all windows anyways, so closing the
window is superfluous. goQuitApplication is also going to be checking for certain
operations to be finished before doing that, which could be influenced by closing
a window early.
MozReview-Commit-ID: 9gJ0ZRn753F
--- a/testing/talos/talos/startup_test/tresize/addon/content/tresize-test.html
+++ b/testing/talos/talos/startup_test/tresize/addon/content/tresize-test.html
@@ -20,17 +20,16 @@ function logResults(data) {
if (typeof dumpLog != "undefined") {
data.forEach(function(line) {
dumpLog(line);
});
window.setTimeout(function() {
TalosPowersContent.goQuitApplication();
- window.close();
}, 0);
} else {
alert(data[0].split("__start_report")[1].split("__end_report")[0]);
}
}
</script>
</head>--- a/testing/talos/talos/startup_test/tspaint_test.html
+++ b/testing/talos/talos/startup_test/tspaint_test.html
@@ -54,17 +54,16 @@ function dumpConsoleAndQuit() {
// Close window asynchronously, there might still be startup operations that still need to run
window.setTimeout(function() {
if (window.dump) {
// eslint-disable-next-line mozilla/avoid-Date-timing
dumpLog("__startTimestamp" + Date.now() + "__endTimestamp\n");
}
TalosPowersContent.goQuitApplication();
- window.close();
}, 0);
}
window.addEventListener("MozAfterPaint", painted, true);
setTimeout(failed, 5000);
</script>
<body></body>