Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp draft
authorFrancois Marier <francois@mozilla.com>
Fri, 01 Jun 2018 15:33:30 -0700
changeset 805419 f4ad52217a006c87742198169cea8b483d4e29d9
parent 805418 264867295deda8de89923bafdbf1840fe34d57b9
child 805420 70eb311be2baf190bb74da4aac32542c08476644
push id112654
push userfmarier@mozilla.com
push dateThu, 07 Jun 2018 20:10:46 +0000
reviewersgcp
bugs1434206
milestone62.0a1
Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp MozReview-Commit-ID: APJ1qhofU3t
toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
--- a/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
+++ b/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
@@ -899,19 +899,21 @@ nsUrlClassifierDBServiceWorker::CacheCom
       updates.AppendElement(tu);
       pParse->ForgetTableUpdates();
     } else {
       LOG(("Completion received, but table %s is not active, so not caching.",
            result->table.get()));
     }
    }
 
-  mClassifier->ApplyFullHashes(&updates);
-  mLastResults = std::move(resultsPtr);
-  return NS_OK;
+  rv = mClassifier->ApplyFullHashes(&updates);
+  if (NS_SUCCEEDED(rv)) {
+    mLastResults = std::move(resultsPtr);
+  }
+  return rv;
 }
 
 nsresult
 nsUrlClassifierDBServiceWorker::CacheResultToTableUpdate(CacheResult* aCacheResult,
                                                          TableUpdate* aUpdate)
 {
   auto tuV2 = TableUpdate::Cast<TableUpdateV2>(aUpdate);
   if (tuV2) {