Bug 1464995 - Minor readability lints. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Tue, 29 May 2018 17:10:07 +0100
changeset 804045 9bf8df7e8459022470151b7f33d437756da0e48e
parent 804044 c5fe849e3f603b0a861737c2420e88de0c6778ce
child 804046 c0bc04c5454e09765ca4b588575a4b4c0e3ef391
push id112293
push userbmo:ato@sny.no
push dateTue, 05 Jun 2018 13:34:59 +0000
reviewerswhimboo
bugs1464995
milestone62.0a1
Bug 1464995 - Minor readability lints. r?whimboo Removes an unnecessary as_ref() cast, a path coercion, and replaces try!() with ?. MozReview-Commit-ID: ASd9kNxDZ3n
testing/mozbase/rust/mozrunner/src/runner.rs
--- a/testing/mozbase/rust/mozrunner/src/runner.rs
+++ b/testing/mozbase/rust/mozrunner/src/runner.rs
@@ -374,34 +374,36 @@ pub mod platform {
 
     /// Searches the system path for `firefox-bin`, then looks for
     /// `Applications/Firefox.app/Contents/MacOS/firefox-bin` under both `/`
     /// (system root) and the user home directory.
     pub fn firefox_default_path() -> Option<PathBuf> {
         if let Some(path) = find_binary("firefox-bin") {
             return Some(path);
         }
+
         let home = env::home_dir();
         for &(prefix_home, trial_path) in [
             (
                 false,
                 "/Applications/Firefox.app/Contents/MacOS/firefox-bin",
             ),
             (true, "Applications/Firefox.app/Contents/MacOS/firefox-bin"),
         ].iter()
         {
-            let path = match (home.as_ref(), prefix_home) {
+            let path = match (home, prefix_home) {
                 (Some(ref home_dir), true) => home_dir.join(trial_path),
                 (None, true) => continue,
-                (_, false) => PathBuf::from(trial_path),
+                (_, false) => trial_path.to_path_buf(),
             };
             if path.exists() {
                 return Some(path);
             }
         }
+
         None
     }
 
     pub fn arg_prefix_char(c: char) -> bool {
         c == '-'
     }
 }
 
@@ -424,26 +426,26 @@ pub mod platform {
             }
         };
         find_binary("firefox.exe")
     }
 
     fn firefox_registry_path() -> Result<Option<PathBuf>, Error> {
         let hklm = RegKey::predef(HKEY_LOCAL_MACHINE);
         for subtree_key in ["SOFTWARE", "SOFTWARE\\WOW6432Node"].iter() {
-            let subtree = try!(hklm.open_subkey_with_flags(subtree_key, KEY_READ));
+            let subtree = hklm.open_subkey_with_flags(subtree_key, KEY_READ)?;
             let mozilla_org = match subtree.open_subkey_with_flags("mozilla.org\\Mozilla", KEY_READ) {
                 Ok(val) => val,
-                Err(_) => continue
+                Err(_) => continue,
             };
-            let current_version: String = try!(mozilla_org.get_value("CurrentVersion"));
-            let mozilla = try!(subtree.open_subkey_with_flags("Mozilla", KEY_READ));
+            let current_version: String = mozilla_org.get_value("CurrentVersion")?;
+            let mozilla = subtree.open_subkey_with_flags("Mozilla", KEY_READ)?;
             for key_res in mozilla.enum_keys() {
-                let key = try!(key_res);
-                let section_data = try!(mozilla.open_subkey_with_flags(&key, KEY_READ));
+                let key = key_res?;
+                let section_data = mozilla.open_subkey_with_flags(&key, KEY_READ)?;
                 let version: Result<String, _> = section_data.get_value("GeckoVer");
                 if let Ok(ver) = version {
                     if ver == current_version {
                         let mut bin_key = key.to_owned();
                         bin_key.push_str("\\bin");
                         if let Ok(bin_subtree) = mozilla.open_subkey_with_flags(bin_key, KEY_READ) {
                             let path: Result<String, _> = bin_subtree.get_value("PathToExe");
                             if let Ok(path) = path {