Bug 1459403: Add a FIXME comment which I think reveals a bug but I haven't confirmed it. r?hiro draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 26 May 2018 23:44:50 +0200
changeset 800297 ca93b91f002b17aa3d908625eb4d599986ebc067
parent 800296 c8eac18672b21fbee7b32ec6a4cce12b0da7b434
child 800298 479b88c6fe7ce322835b738aa1fec61f89383a98
push id111314
push userbmo:emilio@crisal.io
push dateSat, 26 May 2018 22:27:44 +0000
reviewershiro
bugs1459403
milestone62.0a1
Bug 1459403: Add a FIXME comment which I think reveals a bug but I haven't confirmed it. r?hiro MozReview-Commit-ID: DgCfqA5TNzP
servo/components/style/properties/helpers/animated_properties.mako.rs
--- a/servo/components/style/properties/helpers/animated_properties.mako.rs
+++ b/servo/components/style/properties/helpers/animated_properties.mako.rs
@@ -2106,16 +2106,18 @@ fn cross(row1: [f32; 3], row2: [f32; 3])
     [
         row1[1] * row2[2] - row1[2] * row2[1],
         row1[2] * row2[0] - row1[0] * row2[2],
         row1[0] * row2[1] - row1[1] * row2[0]
     ]
 }
 
 impl Animate for Scale3D {
+    // FIXME(emilio): why does this do something different than ComputedScale
+    // for addition?
     fn animate(&self, other: &Self, procedure: Procedure) -> Result<Self, ()> {
         Ok(Scale3D(
             animate_multiplicative_factor(self.0, other.0, procedure)?,
             animate_multiplicative_factor(self.1, other.1, procedure)?,
             animate_multiplicative_factor(self.2, other.2, procedure)?,
         ))
     }
 }